Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Obscuro network icon to add chain method #1535

Closed
wants to merge 2 commits into from
Closed

Add Obscuro network icon to add chain method #1535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f68fbe3
Add Obscuro Network Icon
0xjba Sep 19, 2023
e363132
Add Obscuro Network Icon Parameter to Add Chain RPC Method
0xjba Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added tools/walletextension/api/staticOG/Metamask Network Icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion tools/walletextension/api/staticOG/javascript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ async function addNetworkToMetaMask(ethereum, userID, chainIDDecimal) {
{
chainId: chainIdHex,
chainName: 'Obscuro Testnet',
iconUrls: [https://raw.githubusercontent.com/obscuronet/go-obscuro/main/tools/walletextension/api/staticOG/Metamask%20Network%20Icon.png],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"" required when passing URL string

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach does not work.
See the official Metamask documentation: https://docs.metamask.io/wallet/reference/rpc-api/#wallet_addethereumchain
(parameter is currently ignored)

nativeCurrency: {
name: 'Obscuro',
symbol: 'OBX',
Expand Down Expand Up @@ -228,4 +229,4 @@ const initialize = () => {

}

window.addEventListener(eventDomLoaded, initialize);
window.addEventListener(eventDomLoaded, initialize);
Loading