-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deploys from main - remove migration file for now #1540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@@ -4,6 +4,7 @@ import ( | |||
"database/sql" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the reason for the changes in this file? Since the 002 file was removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It clears up comments and a variable name that threw me off the first time I was reading the code, and adds more info to the error.
Made those changes while debugging the code initially, and felt like they would be good to keep.
Likely it would be good to keep the comment and the error, but perhaps change back the var name if you prefer ?
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Why this change is needed
Fixes deploying testnet/dev-testnet/sepolia from main.
This PR bypasses the use of migration and avoids triggering the bug in the migration code path.
The reason why the migration code is breaking is still to be determined, but likely a string format thing ?
Currently when adding a
002_init.sql
file the enclave fails to start with the following error:What changes were made as part of this PR
002_init.sql
filePR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks