Auto funding script #1543
Merged
Auto funding script #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanIliev545
requested review from
tudor-malene,
otherview and
BedrockSquirrel
added 10 commits
September 22, 2023 13:02
…uced bad batches.
I've had the gas fixes here merged as I needed it to debug stuff, does it need a rebase now that the other one is in? |
BedrockSquirrel
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
LGTM - except maybe getting rid of that 0.9 * tx size thing in the gas calculation we talked about. Bit weird bout the wait for receipts not working too but given that's just sim code I guess is fine for now. Excited to get this one in with the simple transfer to bridge ability 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Please provide a description and a link to the underlying ticket
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks