Reduce tx retries and increase price on retry #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
approved these changes
Sep 25, 2023
| @@ -25,8 +26,9 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| connRetryMaxWait = 10 * time.Minute // after this duration, we will stop retrying to connect and return the failure | |||
| connRetryInterval = 500 * time.Millisecond | |||
| connRetryMaxWait = 10 * time.Minute // after this duration, we will stop retrying to connect and return the failure | |||
There was a problem hiding this comment.
shouldn't this be in block time units as well?
There was a problem hiding this comment.
This is more to do with establishing a connection with the L1 RPC endpoint so not sure blocktime is as important. I don't think we handle this case well though, 10mins feels a bit arbitrary... (FWIW I didn't change this here, it's just whitespace on the line)
Feels very relevant to that pool of L1 URLs we talked about earlier, I'll add a comment on that PR to rethink how we handle and configure this timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks