Tudor/flakyness and perf fixes #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
commented
Sep 27, 2023
| } | ||
|
|
||
| for _, rollup := range rollups { | ||
| l1CompressionBlock, err := rc.storage.FetchBlock(rollup.Header.CompressionL1Head) |
There was a problem hiding this comment.
added some sanity checks here
tudor-malene
commented
Sep 27, 2023
| @@ -35,8 +35,8 @@ func TestInMemoryMonteCarloSimulation(t *testing.T) { | |||
| StartPort: integration.StartPortSimulationInMem, | |||
| IsInMem: true, | |||
| L1SetupData: ¶ms.L1SetupData{}, | |||
| ReceiptTimeout: 30 * time.Second, | |||
| StoppingDelay: 10 * time.Second, | |||
| ReceiptTimeout: 5 * time.Second, | |||
There was a problem hiding this comment.
those timeouts were too long for the in-mem sim
tudor-malene
commented
Sep 27, 2023
| @@ -374,14 +406,27 @@ func (rc *RollupCompression) executeAndSaveIncompleteBatches(calldataRollupHeade | |||
| // check whether the batch is already stored in the database | |||
| b, err := rc.storage.FetchBatchBySeqNo(incompleteBatch.seqNo.Uint64()) | |||
| if err == nil { | |||
| parentHash = b.Hash() | |||
| // chain to a parent only if the batch is not a reorg | |||
| if incompleteBatch.header == nil { | |||
There was a problem hiding this comment.
this is the bug that was causing the flakyness
tudor-malene
commented
Sep 27, 2023
| continue | ||
| } | ||
| if !errors.Is(err, errutil.ErrNotFound) { | ||
| return err | ||
| } | ||
|
|
||
| switch { | ||
| // this batch was re-orged | ||
| case incompleteBatch.header != nil: |
There was a problem hiding this comment.
another rare flakyness issue, when the genesis itself was reorged
tudor-malene
commented
Sep 27, 2023
|
|
||
| // a cache of the l1 blocks used by the current rollup, indexed by their height | ||
| l1BlocksAtHeight := make(map[uint64]*types.Block) | ||
| err = rc.calcL1AncestorsOfHeight(big.NewInt(int64(slices.Min(l1Heights))), rollupL1Block, l1BlocksAtHeight) |
There was a problem hiding this comment.
this is the performance fix to avoid traversing blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed