Performance fixes - speed and memory #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s after they are fetched the first time. 2. Set maximum memory for cache. 3. Reduce cache memory consumption by caching a mapping between a batch hash and a batch sequence
tudor-malene
commented
Oct 2, 2023
| "github.com/obscuronet/go-obscuro/go/enclave/limiters" | ||
|
|
||
| gethcommon "github.com/ethereum/go-ethereum/common" | ||
| "github.com/obscuronet/go-obscuro/go/enclave/core" | ||
| ) | ||
|
|
||
| // rollupProducerImpl encapsulates the logic of decoding rollup transactions submitted to the L1 and resolving them | ||
| // to rollups that the enclave can process. | ||
| type rollupProducerImpl struct { |
There was a problem hiding this comment.
there were a bunch of unused fields, and the comment was out of date
tudor-malene
changed the title
tudor-malene
commented
Oct 2, 2023
| return newRollup, nil | ||
| } | ||
|
|
||
| // createNextRollup - based on a previous rollup and batches will create a new rollup that encapsulate the state |
There was a problem hiding this comment.
outdated comment, and the method had no clear responsibility
tudor-malene
commented
Oct 2, 2023
| // todo - double-check that this signing approach is secure, and it properly includes the entire payload | ||
| if err := s.signRollup(rollup); err != nil { | ||
| if err := s.signRollup(extRollup); err != nil { |
There was a problem hiding this comment.
makes more logical sense to sign over the external rollup
BedrockSquirrel
approved these changes
Oct 2, 2023
| @@ -80,7 +80,7 @@ type BatchExecutor interface { | |||
|
|
|||
| type BatchRegistry interface { | |||
| // BatchesAfter - Given a hash, will return batches following it until the head batch | |||
| BatchesAfter(batchSeqNo uint64, upToL1Height uint64, rollupLimiter limiters.RollupLimiter) ([]*core.Batch, error) | |||
| BatchesAfter(batchSeqNo uint64, upToL1Height uint64, rollupLimiter limiters.RollupLimiter) ([]*core.Batch, []*types.Block, error) | |||
There was a problem hiding this comment.
should update the comment on this probably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
What changes were made as part of this PR
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks