Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SepoliaTestnet as an environment for network tests #1574

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

BedrockSquirrel
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel commented Oct 3, 2023

Why this change is needed

Now that the sepolia faucet is working we can use SepoliaTestnet as an environment on the network tests.

Renamed the RPC URL field as there's no requirement for it to be websocket for testing unless the test is doing some subscription stuff. This means we can configure a public sepolia URL instead of an infura URL requiring API key.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@BedrockSquirrel BedrockSquirrel merged commit 61c2cda into main Oct 3, 2023
2 checks passed
@BedrockSquirrel BedrockSquirrel deleted the matt/setup-sepolia-networktests-env branch October 3, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants