Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add balance endpoint to faucet for monitoring #1577

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

BedrockSquirrel
Copy link
Collaborator

Why this change is needed

We need to be notified when sepolia faucet is getting low on funds but the account balance can't be easily monitored because you need signed viewing key.

Endpoint will let us add it to the periodic monitoring.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Contributor

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BedrockSquirrel BedrockSquirrel merged commit 1dea9e9 into main Oct 3, 2023
2 checks passed
@BedrockSquirrel BedrockSquirrel deleted the matt/add-faucet-balance-check branch October 3, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants