Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove costly select #1583

Merged
merged 2 commits into from
Oct 6, 2023
Merged

remove costly select #1583

merged 2 commits into from
Oct 6, 2023

Conversation

tudor-malene
Copy link
Collaborator

@tudor-malene tudor-malene commented Oct 6, 2023

Why this change is needed

To improve the performance of "create batch", remove costly select called for each batch.

It also fixes a small flakyness that was causing sim tests to fail due to duplicated genesis

@tudor-malene tudor-malene temporarily deployed to dev-testnet October 6, 2023 08:31 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to dev-testnet October 6, 2023 08:37 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to dev-testnet October 6, 2023 08:37 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 08:48 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 08:54 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 08:54 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 09:10 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 09:16 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 09:16 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 09:18 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 09:24 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 09:51 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 09:58 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 09:58 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 10:00 — with GitHub Actions Inactive
Copy link
Contributor

@StefanIliev545 StefanIliev545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-malene tudor-malene merged commit 0c161a9 into main Oct 6, 2023
8 of 10 checks passed
@tudor-malene tudor-malene deleted the tudor/perf_fix branch October 6, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants