Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block head cache #1589

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Add block head cache #1589

merged 1 commit into from
Oct 9, 2023

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

there is a slight performance degradation on testnet.
The query for the block head is one potential cause

What changes were made as part of this PR

  • cache the l1 head

Copy link
Contributor

@StefanIliev545 StefanIliev545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided that the assumption here is that we cache the hash instead of the block, because its the responsibility of the storage interface to be doing this, correct?

@tudor-malene
Copy link
Collaborator Author

LGTM, provided that the assumption here is that we cache the hash instead of the block, because its the responsibility of the storage interface to be doing this, correct?

yeah. the storage caches stuff

@tudor-malene tudor-malene merged commit 1bc26e6 into main Oct 9, 2023
8 of 9 checks passed
@tudor-malene tudor-malene deleted the tudor/fix_head_block_perf branch October 9, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants