Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save logs #1594

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Save logs #1594

merged 3 commits into from
Oct 12, 2023

Conversation

StefanIliev545
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Contributor

@moraygrieve moraygrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@otherview
Copy link
Contributor

Will this make us burn through our storage rather quickly ?

@moraygrieve
Copy link
Contributor

moraygrieve commented Oct 12, 2023

@otherview Retention is 2 days (we could reduce to 1 probably) and we don't deploy that much so I would say this should be fine. At the moment we need them to get all the L1 contract addresses.

@moraygrieve
Copy link
Contributor

moraygrieve commented Oct 12, 2023

Do we need to do for the l1 deployer container logs also @StefanIliev545 ?

@moraygrieve moraygrieve merged commit 7dfd9ab into main Oct 12, 2023
3 checks passed
@moraygrieve moraygrieve deleted the siliev/save-logs-always-deployer branch October 12, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants