Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moray/save l1 deployer logs #1598

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Moray/save l1 deployer logs #1598

merged 2 commits into from
Oct 13, 2023

Conversation

moraygrieve
Copy link
Contributor

We need to save the L1 deployer container logs to get some of the L1 contract addresses

@coderabbitai
Copy link

coderabbitai bot commented Oct 13, 2023

Walkthrough

The changes primarily focus on renaming and modifying steps related to container logs in the GitHub Actions workflow for both L1 and L2 deployers. The conditions for saving and uploading logs have been altered, and the retention days for the artifacts have been reduced from 2 to 1.

Changes

File Summary
.github/workflows/manual-deploy-testnet-l2.yml Renamed steps for saving and uploading container logs for both L1 and L2 deployers. Removed the condition if: failure() from these steps. Reduced the retention days for the artifacts "deploy-l1-artifacts" and "deploy-l2-artifacts" from 2 to 1.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between b5620b1 and c5c0b6e.
Files selected for processing (1)
  • .github/workflows/manual-deploy-testnet-l2.yml (3 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/manual-deploy-testnet-l2.yml

@moraygrieve moraygrieve merged commit 3d3c12c into main Oct 13, 2023
1 of 2 checks passed
@moraygrieve moraygrieve deleted the moray/save_l1_deployer_logs branch October 13, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants