Updates GH Inputs to reflect current networks #1602
Conversation
WalkthroughThe changes primarily involve renaming the 'testnet' option to 'uat-testnet' across multiple GitHub workflow files and updating the addresses in a test function. This suggests a shift from a development testnet to a user acceptance testing (UAT) testnet. Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (3)
- .github/workflows/manual-deploy-testnet-l1.yml (1 hunks)
- .github/workflows/manual-deploy-testnet-l2.yml (1 hunks)
- .github/workflows/manual-recover-network-funds.yml (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/manual-deploy-testnet-l2.yml
- .github/workflows/manual-recover-network-funds.yml
Additional comments (Suppressed): 1
.github/workflows/manual-deploy-testnet-l1.yml (1)
- 25-28: The option
'testnet'has been replaced with'uat-testnet'. Ensure that all references to this workflow in the codebase have been updated to use the new option'uat-testnet'instead of'testnet'. Also, verify that the 'uat-testnet' environment is properly set up and ready for deployment.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (4)
- .github/workflows/manual-deploy-testnet-l1.yml (2 hunks)
- .github/workflows/manual-deploy-testnet-l2.yml (2 hunks)
- .github/workflows/manual-upgrade-testnet-l2.yml (2 hunks)
- integration/manualtests/connection_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/manual-deploy-testnet-l2.yml
Additional comments (Suppressed): 7
.github/workflows/manual-deploy-testnet-l1.yml (3)
25-28: The 'testnet' option has been replaced with 'uat-testnet'. Ensure that all instances where this workflow is triggered have been updated to use the new 'uat-testnet' option.
43-51: The environment variables for the 'uat-testnet' have been set. Ensure that these values are correct and correspond to the resources in the UAT testnet environment.
52-60: The environment variables for the 'dev-testnet' remain the same. However, the TEST_BRIDGE_ADDRESS is the same for both 'uat-testnet' and 'dev-testnet'. If these two environments are supposed to have different bridge addresses, this could be an issue.
.github/workflows/manual-upgrade-testnet-l2.yml (2)
28-28: The 'testnet' option has been replaced with 'uat-testnet'. Ensure that all references to this input in the workflow have been updated accordingly.
233-235: The event type for the repository dispatch has been updated from 'testnet_upgraded' to 'uat_testnet_upgraded'. Make sure that the 'obscuro-test' repository is set up to handle this new event type.
integration/manualtests/connection_test.go (2)
- 20-22: The addresses for the Obscuro Gateway have been updated to point to the UAT testnet. Ensure that the UAT testnet is ready and available for these tests to run successfully.
- ogHTTPAddress := "https://dev-testnet.obscu.ro:443" - ogWSAddress := "wss://dev-testnet.obscu.ro:81" + ogHTTPAddress := "https://uat-testnet.obscu.ro" + ogWSAddress := "wss://uat-testnet.obscu.ro:81"
- 18-18: The skip directive for the test has been commented out. If this is intentional and you want this test to run during the test execution, no action is needed. Otherwise, if you want to skip this test during the test execution, uncomment the skip directive.
- //t.Skip("skip manual tests") + t.Skip("skip manual tests")
Why this change is needed
Please provide a description and a link to the underlying ticket
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks