Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update og namings in the GH #1603

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update og namings in the GH #1603

merged 1 commit into from
Oct 16, 2023

Conversation

otherview
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2023

Walkthrough

The changes primarily focus on updating environment variable names and values in GitHub Actions workflows for different testnet types. The modifications enhance the descriptiveness and formatting of the RESOURCE_TAG_NAME and RESOURCE_STARTING_NAME variables, improving readability and maintainability.

Changes

File Summary
.github/workflows/manual-deploy-obscuro-gateway-database.yml Updated RESOURCE_STARTING_NAME and RESOURCE_TAG_NAME values based on the testnet_type input. The changes involve renaming and reformatting the values.
.github/workflows/manual-deploy-obscuro-gateway.yml Revised RESOURCE_TAG_NAME variables for uat-testnet, dev-testnet, and sepolia-testnet to follow the pattern obscuro-gateway-{testnet-type}-latest.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

@otherview otherview requested a review from moraygrieve October 16, 2023 15:12
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between a18f862 and 269c3d0.
Files selected for processing (2)
  • .github/workflows/manual-deploy-obscuro-gateway-database.yml (1 hunks)
  • .github/workflows/manual-deploy-obscuro-gateway.yml (1 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/manual-deploy-obscuro-gateway-database.yml
  • .github/workflows/manual-deploy-obscuro-gateway.yml

@otherview otherview merged commit 299d509 into main Oct 16, 2023
3 of 4 checks passed
@otherview otherview deleted the pedro/update_og_gh branch October 16, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants