Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Upgrade list query #1604

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fixes Upgrade list query #1604

merged 1 commit into from
Oct 16, 2023

Conversation

otherview
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2023

Walkthrough

The change involves a minor but crucial update to a shell script in the GitHub workflow. The update ensures proper substitution of a variable in a query syntax, which is necessary for correctly filtering a list of Virtual Machines based on their tag value.

Changes

File Summary
.github/workflows/manual-upgrade-testnet-l2.yml Updated the query syntax in a shell script to include double quotes around the variable ${{vars.RESOURCE_TAG_NAME}}. This change ensures proper substitution and correct filtering of the VM list based on the tag value.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 299d509 and f77c049.
Files selected for processing (1)
  • .github/workflows/manual-upgrade-testnet-l2.yml (1 hunks)
Additional comments (Suppressed): 1
.github/workflows/manual-upgrade-testnet-l2.yml (1)
  • 80-80: The change from using ${{vars.RESOURCE_TAG_NAME}} to \"${{vars.RESOURCE_TAG_NAME}}\" in the query syntax is a good fix. It ensures that the variable is correctly substituted in the query, which is necessary for the correct operation of the script and the accurate retrieval of the VM hostname and build number.

@otherview otherview merged commit d1036cf into main Oct 16, 2023
1 of 2 checks passed
@otherview otherview deleted the pedro/fix_upgrade_gh branch October 16, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants