Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stuck at revoke userID #1605

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix stuck at revoke userID #1605

merged 1 commit into from
Oct 17, 2023

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Oct 16, 2023

Why this change is needed

https://github.com/obscuronet/obscuro-internal/issues/2288

What changes were made as part of this PR

Do not display buttons and accounts table if Metamask is not installed

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@zkokelj zkokelj marked this pull request as ready for review October 16, 2023 15:50
@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2023

Walkthrough

The changes primarily focus on the user interface, specifically hiding and displaying certain elements. The "Join" and "Revoke UserID" buttons are hidden, and the "Add Account" and "Add All Accounts" elements are removed. The "accountsTable" element is also hidden, and a connecting message is displayed in the "statusArea" element. These changes seem to be related to the presence of Metamask.

Changes

File Path Summary
.../api/staticOG/index.html The "Join" and "Revoke UserID" buttons are hidden by adding the inline style display: none to their HTML elements.
.../api/staticOG/javascript.js The "Add Account" and "Add All Accounts" elements are removed. The "accountsTable" element is hidden, and a connecting message is displayed in the "statusArea" element.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between d1036cf and 1e0dd72.
Files selected for processing (2)
  • tools/walletextension/api/staticOG/index.html (1 hunks)
  • tools/walletextension/api/staticOG/javascript.js (2 hunks)
Files skipped from review due to trivial changes (2)
  • tools/walletextension/api/staticOG/index.html
  • tools/walletextension/api/staticOG/javascript.js

@zkokelj zkokelj merged commit 31d9b7f into main Oct 17, 2023
2 checks passed
@zkokelj zkokelj deleted the ziga/fix_stuck_revoke_userID branch October 17, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants