Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes for deployment #1607

Merged
merged 1 commit into from
Oct 16, 2023
Merged

CI fixes for deployment #1607

merged 1 commit into from
Oct 16, 2023

Conversation

otherview
Copy link
Contributor

Why this change is needed

  • Obscuro gateway now uses correct tag
  • Obscuro scan v2 now has sepolia option

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2023

Walkthrough

The changes primarily focus on enhancing the deployment process of the Obscuro project. They introduce a new tag for the virtual machine created in the Obscuro Gateway deployment and extend the Obscuro Scan deployment to support a new testnet type, 'sepolia-testnet', with its specific configurations.

Changes

File Summary
.github/workflows/manual-deploy-obscuro-gateway.yml Updated the deploygroup tag value from ObscuroNode to ObscuroGateway in the az vm create command, altering the tag associated with the created VM.
.github/workflows/manual-deploy-obscuro-scan-2.yml Added 'sepolia-testnet' as a new testnet type and set up specific Obscuro Scan variables for it, allowing for different configurations and deployments based on the selected testnet type.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between d1036cf and d0e2c5f.
Files selected for processing (2)
  • .github/workflows/manual-deploy-obscuro-gateway.yml (1 hunks)
  • .github/workflows/manual-deploy-obscuro-scan-2.yml (2 hunks)
Additional comments (Suppressed): 3
.github/workflows/manual-deploy-obscuro-scan-2.yml (2)
  • 14-17: The new testnet type 'sepolia-testnet' has been added to the options. Ensure that the rest of the codebase and any dependent systems are updated to handle this new testnet type.

  • 28-33: The environment variables for the 'sepolia-testnet' are being set here. Make sure that the values for the build tags and the node host are correct and that they are consistent with the rest of the system.

.github/workflows/manual-deploy-obscuro-gateway.yml (1)
  • 97-97: The deploygroup tag value has been changed from ObscuroNode to ObscuroGateway. Ensure that any scripts, services, or systems that rely on this tag are updated to reflect this change. This could impact resource grouping, filtering, or identification in your Azure environment.
- --tags deploygroup=ObscuroNode-${{env.RESOURCE_STARTING_NAME}}-${{ GITHUB.RUN_NUMBER }}  ${{env.RESOURCE_TAG_NAME}}=true \
+ --tags deploygroup=ObscuroGateway-${{env.RESOURCE_STARTING_NAME}}-${{ GITHUB.RUN_NUMBER }}  ${{env.RESOURCE_TAG_NAME}}=true \

Copy link
Contributor

@moraygrieve moraygrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@otherview otherview merged commit 94d12bd into main Oct 16, 2023
1 of 2 checks passed
@otherview otherview deleted the pedro/ci_fixes branch October 16, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants