Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for estimate gas failing when gasPrice included. #1610

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

StefanIliev545
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@coderabbitai
Copy link

coderabbitai bot commented Oct 17, 2023

Walkthrough

The proposed changes primarily focus on improving the clarity and consistency of the code in the ExtractEthCall function. The variable value has been renamed to gasPrice and its type has been updated to *hexutil.Big. Similarly, the valueVal variable has been renamed to gasPriceVal and its type has been updated to *big.Int.

Changes

File Summary
.../gethencoding/geth_encoding.go The ExtractEthCall function has been updated for better clarity and consistency. The variable value has been renamed to gasPrice and its type has been updated to *hexutil.Big. The valueVal variable has been renamed to gasPriceVal and its type has been updated to *big.Int.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 94d12bd and e6829ef.
Files selected for processing (1)
  • go/common/gethencoding/geth_encoding.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • go/common/gethencoding/geth_encoding.go

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StefanIliev545 StefanIliev545 merged commit a25b5b4 into main Oct 18, 2023
2 checks passed
@StefanIliev545 StefanIliev545 deleted the siliev/estimate-gas-errors branch October 18, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants