Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ziga/fix og metamask urls #1611

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Ziga/fix og metamask urls #1611

merged 3 commits into from
Oct 17, 2023

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Oct 17, 2023

Why this change is needed

Obscuro Gateway was not setting Metamask URLs correctly.

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@zkokelj zkokelj marked this pull request as ready for review October 17, 2023 13:18
@coderabbitai
Copy link

coderabbitai bot commented Oct 17, 2023

Walkthrough

The changes primarily focus on the modification of URLs in the getNetworkName and getRPCFromUrl functions within the javascript.js file. The trailing slashes in the URLs have been removed, which affects the returned network names and RPC endpoints based on the provided gateway address.

Changes

File Path Summary
.../api/staticOG/javascript.js The URLs in the getNetworkName and getRPCFromUrl functions have been updated. Trailing slashes have been removed, affecting the returned network names and RPC endpoints. For example, 'https://uat-testnet.obscu.ro' now returns 'Obscuro UAT-Testnet' and 'https://rpc.uat-testnet.obscu.ro' respectively.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between b5722cd and cbddd7b.
Files selected for processing (1)
  • tools/walletextension/api/staticOG/javascript.js (2 hunks)
Files skipped from review due to trivial changes (1)
  • tools/walletextension/api/staticOG/javascript.js

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between cbddd7b and 89c658d.
Files selected for processing (1)
  • tools/walletextension/api/staticOG/javascript.js (2 hunks)
Additional comments (Suppressed): 2
tools/walletextension/api/staticOG/javascript.js (2)
  • 57-64: The function getNetworkName has been updated to remove the trailing slashes from the URLs. Ensure that all calls to this function throughout the codebase have been updated to match the new URLs.

  • 69-81: The function getRPCFromUrl has been updated to remove the trailing slashes from the URLs. Also, the case for 'https://testnet.obscu.ro' has been commented out. If this is intentional, ensure that all calls to this function throughout the codebase have been updated to match the new URLs and that the removal of 'https://testnet.obscu.ro' does not break any existing functionality.

@zkokelj zkokelj merged commit c4140ad into main Oct 17, 2023
@zkokelj zkokelj deleted the ziga/fix_og_metamask_urls branch October 17, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants