-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ziga/fix og metamask urls #1611
Conversation
WalkthroughThe changes primarily focus on the modification of URLs in the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- tools/walletextension/api/staticOG/javascript.js (2 hunks)
Files skipped from review due to trivial changes (1)
- tools/walletextension/api/staticOG/javascript.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- tools/walletextension/api/staticOG/javascript.js (2 hunks)
Additional comments (Suppressed): 2
tools/walletextension/api/staticOG/javascript.js (2)
57-64: The function
getNetworkName
has been updated to remove the trailing slashes from the URLs. Ensure that all calls to this function throughout the codebase have been updated to match the new URLs.69-81: The function
getRPCFromUrl
has been updated to remove the trailing slashes from the URLs. Also, the case for 'https://testnet.obscu.ro' has been commented out. If this is intentional, ensure that all calls to this function throughout the codebase have been updated to match the new URLs and that the removal of 'https://testnet.obscu.ro' does not break any existing functionality.
Why this change is needed
Obscuro Gateway was not setting Metamask URLs correctly.
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks