Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping table behind spinner until loaded #1618

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Keeping table behind spinner until loaded #1618

merged 1 commit into from
Oct 20, 2023

Conversation

CaisManai
Copy link
Contributor

Keeping table behind spinner until completely loaded.

@CaisManai CaisManai requested a review from 0xjba October 20, 2023 17:26
@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2023

Walkthrough

The changes primarily involve the repositioning of code lines responsible for hiding and showing elements on a webpage. This modification does not affect any global structures, variables, interfaces, return values, or exceptions.

Changes

File Path Summary
.../api/staticOG/javascript.js The diff removes two lines of code that hide and show elements on the page. These lines are relocated elsewhere in the code, without altering any global data structures, variables, interfaces, return values, or exceptions.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.

CodeRabbit Commands

  • Enter @coderabbitai pause as a PR comment to pause the reviews on a PR.
  • Enter @coderabbitai resume as a PR comment to resume the paused reviews.
  • For on-demand reviews, enter @coderabbitai review as a PR comment to trigger a review. This is useful when reviews are automatic disabled at the repository level.
  • Enter @coderabbitai: ignore in the PR description to stop a specific PR from being reviewed.

Note these commands work only in the PR comment. For conversations with the bot, please use the review comments on code diffs or files.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 4c5c8b2 and ece1ef3.
Files selected for processing (1)
  • tools/walletextension/api/staticOG/javascript.js (2 hunks)
Files skipped from review due to trivial changes (1)
  • tools/walletextension/api/staticOG/javascript.js

Copy link
Contributor

@0xjba 0xjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@CaisManai CaisManai merged commit 401acba into main Oct 20, 2023
1 of 2 checks passed
@CaisManai CaisManai deleted the Gateway-UI-Fix branch October 20, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants