Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for basic gateway package #1619
Initial commit for basic gateway package #1619
Changes from all commits
fcedafe
d981d50
c85c563
d914756
9aad2b3
e6c941e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
registerAccount
method constructs a message and signs it using the provider, but it does not handle the case where the provider fails to sign the message. This could lead to unexpected behavior or errors later on. Consider adding a check to ensure thatsignature
is not null or empty before proceeding with the authentication request.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
userID
,http
, andws
methods return values derived fromthis.userId
, but do not handle the case wherethis.userId
is null or empty. This could lead to unexpected behavior or errors later on. Consider adding checks to ensure thatthis.userId
is not null or empty before returning these values.Committable suggestion (Beta)