Respond with latest for pending block number requests #1623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Some tools are making RPC requests to us with 'pending' blocknumber which was erroring.
These are the eth block number options:
They don't map that well to obscuro batches. For now this treats those requests the same as for latest block because it's better than failing, and I will create an issue for us to revisit this.
We may eventually want to respond with the latest batch that's been rolled up for the 'finalized' flag but maybe that's not intuitive behaviour when rollups may take hours.
What changes were made as part of this PR
Handle the nuanced cases of eth block number all as 'latest' batch for now, in particular
pending
which wasn't supported.PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks