Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObscuroScan: favicon, title, align icons #1625

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

BedrockSquirrel
Copy link
Collaborator

Why this change is needed

The lowest hanging fruit from the OS feedback: https://github.com/obscuronet/obscuro-internal/issues/2323

Before

image
image

After

image
image

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@coderabbitai
Copy link

coderabbitai bot commented Oct 26, 2023

Walkthrough

The changes primarily focus on enhancing the user interface and improving logging in the web server. The frontend updates include modifications to the favicon, page title, and images in the Vue components. The backend change adds logging to the server start process.

Changes

File Summary
.../webserver/webserver.go Added logging statements to the Start method of the WebServer struct.
.../frontend/index.html Updated the favicon link and changed the title of the HTML page.
.../components/BotBarItem.vue Modified the template and style of a component to improve image display and accessibility.
.../views/NavbarView.vue Replaced the image source in the HTML template for cosmetic purposes.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9a37065 and e1aa08c.
Files ignored due to filter (7)
  • tools/obscuroscan_v2/frontend/public/favicon-32x32.png
  • tools/obscuroscan_v2/frontend/public/favicon.ico
  • tools/obscuroscan_v2/frontend/src/assets/imgs/github-mark-white.png
  • tools/obscuroscan_v2/frontend/src/assets/imgs/obscuro.svg
  • tools/obscuroscan_v2/frontend/src/assets/imgs/obscuro_logo_black.png
  • tools/obscuroscan_v2/frontend/src/assets/imgs/obscuroscan_logo.png
  • tools/obscuroscan_v2/frontend/src/assets/logo.svg
Files selected for processing (4)
  • tools/obscuroscan_v2/backend/webserver/webserver.go (1} hunks)
  • tools/obscuroscan_v2/frontend/index.html (1} hunks)
  • tools/obscuroscan_v2/frontend/src/components/BotBarItem.vue (2} hunks)
  • tools/obscuroscan_v2/frontend/src/views/NavbarView.vue (1} hunks)
Files skipped from review due to trivial changes (4)
  • tools/obscuroscan_v2/backend/webserver/webserver.go
  • tools/obscuroscan_v2/frontend/index.html
  • tools/obscuroscan_v2/frontend/src/components/BotBarItem.vue
  • tools/obscuroscan_v2/frontend/src/views/NavbarView.vue

Copy link
Contributor

@zkokelj zkokelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@BedrockSquirrel BedrockSquirrel merged commit a96105d into main Oct 26, 2023
@BedrockSquirrel BedrockSquirrel deleted the matt/obscuroscan-minor-tidy-up branch October 26, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants