ObscuroScan: load eth price on init #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes primarily focus on modifying the polling interval for price updates in the frontend and adjusting the default server address in the backend. The polling interval is now set to 1 minute, improving readability and maintainability. The server address has been changed to "0.0.0.0:43910". Additionally, the polling process now starts with an immediate fetch callback execution. Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (6)
- tools/obscuroscan_v2/backend/cmd/cli.go (1} hunks)
- tools/obscuroscan_v2/frontend/src/lib/config.dev.js (1} hunks)
- tools/obscuroscan_v2/frontend/src/lib/config.js (1} hunks)
- tools/obscuroscan_v2/frontend/src/lib/config.prod.js (1} hunks)
- tools/obscuroscan_v2/frontend/src/lib/poller.js (1} hunks)
- tools/obscuroscan_v2/frontend/src/stores/priceStore.js (2} hunks)
Files skipped from review due to trivial changes (4)
- tools/obscuroscan_v2/frontend/src/lib/config.dev.js
- tools/obscuroscan_v2/frontend/src/lib/config.js
- tools/obscuroscan_v2/frontend/src/lib/config.prod.js
- tools/obscuroscan_v2/frontend/src/lib/poller.js
Additional comments: 2
tools/obscuroscan_v2/backend/cmd/cli.go (1)
- 12-12: The server address port has been changed from 80 to 43910. Ensure that this port is open and properly configured in your network settings to avoid connection issues. Also, verify that all parts of the system that interact with this server are updated to use the new port.
tools/obscuroscan_v2/frontend/src/stores/priceStore.js (1)
- 12-12: The polling interval has been changed from
60*Config.pollingIntervaltoConfig.pricePollingInterval. Ensure that thepricePollingIntervalis defined and set correctly in theConfigclass. Also, verify that this change doesn't affect other parts of the code that might be using the oldpollingInterval.
| } catch (error) { | ||
| console.error("Failed to fetch count:", error); | ||
| } | ||
| }, | ||
|
|
||
| startPolling() { | ||
| async startPolling() { |
There was a problem hiding this comment.
The startPolling function has been made asynchronous, but there are no await expressions inside it. If you plan to add asynchronous operations inside this function in the future, this change is fine. Otherwise, it's unnecessary to declare it as async.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- tools/obscuroscan_v2/frontend/src/stores/priceStore.js (2} hunks)
Files skipped from review due to trivial changes (1)
- tools/obscuroscan_v2/frontend/src/stores/priceStore.js
otherview
reviewed
Oct 27, 2023
| @@ -9,7 +9,7 @@ export const usePriceStore = defineStore({ | |||
| poller: new Poller(() => { | |||
| const store = usePriceStore(); | |||
| store.fetch(); | |||
| }, 60*Config.pollingInterval) | |||
| }, Config.pricePollingInterval) | |||
There was a problem hiding this comment.
Is there a need to have the price updated at the second ? Also, I think it happened to me getting limit rated for polling too fast, might want to avoid the client limit rated for polling too fast too.
otherview
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Currently it takes one minute before the eth price is requested so we see a loading circle. The other data also has a slight (1 second) delay before it loads because it waits for its polling interval.
What changes were made as part of this PR
Change the poller semantics to make the request immediately when started and then at the interval thereafter.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks