Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obscuroscan#2323 #1640

Merged
merged 61 commits into from
Nov 23, 2023
Merged

Obscuroscan#2323 #1640

merged 61 commits into from
Nov 23, 2023

Conversation

Jennievon
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

https://github.com/obscuronet/obscuro-internal/issues/2323

What changes were made as part of this PR

Please provide a high-level list of the changes made

  • Revamp of Obscuroscan

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link

coderabbitai bot commented Nov 13, 2023

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review.

55 files out of 112 files are above the max files limit of 50.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@Jennievon Jennievon changed the title Jennifer/new scan config setup Obscuroscan#2323 Nov 13, 2023
@Jennievon Jennievon self-assigned this Nov 13, 2023
@otherview
Copy link
Contributor

@Jennievon let's get this PR merged and push new development into new PRs :)

@otherview
Copy link
Contributor

Quick update - This was discussed offline and it will be added a new Dockerfile for the FE v3 and the new v3 workflow as the last items before merging to main.

uses: "azure/aci-deploy@v1"
with:
resource-group: ${{ secrets.RESOURCE_GROUP }}
dns-name-label: ${{ github.event.inputs.testnet_type }}-obscuro-scan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this dns so it doesnt collide with the existing one

Suggested change
dns-name-label: ${{ github.event.inputs.testnet_type }}-obscuro-scan
dns-name-label: ${{ github.event.inputs.testnet_type }}-obscuro-scan-v3

tools/obscuroscan_v3/frontend/Dockerfile Outdated Show resolved Hide resolved
- rm manual http-server installation
@Jennievon Jennievon merged commit 8712e26 into main Nov 23, 2023
1 of 2 checks passed
@Jennievon Jennievon deleted the jennifer/new-scan-config-setup branch November 23, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants