-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obscuroscan#2323 #1640
Obscuroscan#2323 #1640
Conversation
Important Auto Review SkippedMore than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review. 55 files out of 112 files are above the max files limit of 50. TipsChat with CodeRabbit Bot (
|
…jennifer/new-scan-config-setup
…jennifer/scan-updates
…jennifer/new-scan-config-setup
…jennifer/scan-updates
…bscuronet/go-obscuro into jennifer/scan-updates
refactor: naming conventions
- default layout uniformity
@Jennievon let's get this PR merged and push new development into new PRs :) |
…jennifer/new-scan-config-setup
Quick update - This was discussed offline and it will be added a new Dockerfile for the FE v3 and the new v3 workflow as the last items before merging to main. |
uses: "azure/aci-deploy@v1" | ||
with: | ||
resource-group: ${{ secrets.RESOURCE_GROUP }} | ||
dns-name-label: ${{ github.event.inputs.testnet_type }}-obscuro-scan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this dns so it doesnt collide with the existing one
dns-name-label: ${{ github.event.inputs.testnet_type }}-obscuro-scan | |
dns-name-label: ${{ github.event.inputs.testnet_type }}-obscuro-scan-v3 |
- rm manual http-server installation
Why this change is needed
Please provide a description and a link to the underlying ticket
https://github.com/obscuronet/obscuro-internal/issues/2323
What changes were made as part of this PR
Please provide a high-level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks