Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacing github links #1647

Merged
merged 3 commits into from
Nov 16, 2023
Merged

replacing github links #1647

merged 3 commits into from
Nov 16, 2023

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

Rebranding

What changes were made as part of this PR

  • replace the github links

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 16, 2023 •
edited
Loading

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review.

209 files out of 266 files are above the max files limit of 50.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

BedrockSquirrel
BedrockSquirrel approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after skim

go/enclave/container/enclave_container.go

obscuroGenesis "github.com/obscuronet/go-obscuro/go/enclave/genesis"
obscuroGenesis "github.com/ten-protocol/go-ten/go/enclave/genesis"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess changing aliases like these can come later as we update the code references?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. that's what I have in mind.
a step by step approach, so it can be reviewed sanely

@tudor-malene
update go files
df48901
@tudor-malene
Merge remote-tracking branch 'origin/main' into tudor/s_obscuro_ten_g
db523ee 
# Conflicts:
#	developer_onboarding_guide.md
#	docs/_docs/testnet/Introduction.md
#	docs/_docs/testnet/starting-a-node.md
#	docs/_docs/wallet-extension/wallet-extension.md
#	docs/index.md
#	tools/faucet/README.md
@tudor-malene tudor-malene merged commit 309b240 into main Nov 16, 2023
@tudor-malene tudor-malene deleted the tudor/s_obscuro_ten_g branch November 16, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BedrockSquirrel BedrockSquirrel BedrockSquirrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tudor-malene @BedrockSquirrel