Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting sepolia account to admin. #1651

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Promoting sepolia account to admin. #1651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion contracts/deployment_scripts/testnet/layer1/002_add_bridge_admin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
// Deploy a constant supply (constructor mints) erc20
await deployments.execute('ObscuroBridge', {
from: deployer
}, 'promoteToAdmin', '0xE09a37ABc1A63441404007019E5BC7517bE2c43f')
}, 'promoteToAdmin', '0xE09a37ABc1A63441404007019E5BC7517bE2c43f');

await deployments.execute('ObscuroBridge', {
from: deployer
}, 'promoteToAdmin', '0xeC3f9B38a3B30AdC9fB3dF3a0D8f50127E6c2C8f');
};

Comment on lines 18 to 27
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes introduce a new administrative function to promote two Ethereum addresses to admin status within the ObscuroBridge contract. Ensure that the addresses '0xE09a37ABc1A63441404007019E5BC7517bE2c43f' and '0xeC3f9B38a3B30AdC9fB3dF3a0D8f50127E6c2C8f' are correct and intended to be granted admin rights. Additionally, confirm that the promoteToAdmin function has been properly tested and audited, especially since it involves privilege escalation which can be a sensitive change in terms of security.

Also, verify that the deployments.execute function has appropriate error handling in case the transaction fails, and consider the implications of transaction ordering, in case these promotions need to occur in a specific sequence or atomic transaction.

Lastly, ensure that the function promoteToAdmin is secure and does not introduce any vulnerabilities, such as the potential for unauthorized privilege escalation, and that its use is compliant with the overall governance and security policies of the project.

export default func;
Expand Down
Loading