Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 contracts: increase timeout for extra transactions #1671

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

BedrockSquirrel
Copy link
Collaborator

Why this change is needed

Testnet deployments are failing because new transactions on the L1 contract deployer (to write important contract addresses to the management contract) have slowed the script down but the timeout wasn't increased.

What changes were made as part of this PR

Bump the allowed time from 1min to 3mins (was taking about 1.5mins on dev-testnet, plus some padding for sepolia being slower).

When things go wrong the container generally fails fast so shouldn't add much time when there are issues.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link

coderabbitai bot commented Nov 28, 2023

Walkthrough

The change extends the timeout duration for a container that executes L1 transactions from one minute to three minutes. This adjustment is likely in response to issues with transaction mining times, ensuring that the system allows a longer period before timing out and proceeding with subsequent operations.

Changes

File Path Change Summary
.../l1contractdeployer/docker.go Increased the timeout duration for waiting on a container to finish L1 transactions from 1 minute to 3 minutes.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 1d08a78 and 4812568.
Files selected for processing (1)
  • testnet/launcher/l1contractdeployer/docker.go (1 hunks)
Additional comments: 1
testnet/launcher/l1contractdeployer/docker.go (1)
  • 70-74: The increase in timeout duration from 1 minute to 3 minutes in RetrieveL1ContractAddresses function is a reasonable change to accommodate the additional time needed for L1 transactions to be mined. Ensure that this change has been tested across different environments to confirm that it does not introduce any unintended side effects.

Copy link
Contributor

@moraygrieve moraygrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BedrockSquirrel BedrockSquirrel merged commit 5bf20d9 into main Nov 28, 2023
1 of 2 checks passed
@BedrockSquirrel BedrockSquirrel deleted the matt/fix-testnet-deployments branch November 28, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants