-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obscuroscan now deploys to port 80 #1675
Conversation
WalkthroughThe GitHub workflow file Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/manual-deploy-obscuro-scan-3.yml (1 hunks)
Additional comments: 1
.github/workflows/manual-deploy-obscuro-scan-3.yml (1)
- 58-70: The changes to the
dns-name-label
andname
fields, as well as the addition of the--p80
argument in thecommand-line
field, align with the summary. Verify that the--p80
flag is correctly implemented in thenpm run start
command to ensure the application listens on port 80 as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6061b6f
to
553948d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/manual-deploy-obscuro-scan-3.yml (1 hunks)
Additional comments: 3
.github/workflows/manual-deploy-obscuro-scan-3.yml (3)
61-63: The addition of the "-v3" suffix to the
dns-name-label
andname
properties is consistent with the versioning update mentioned in the summary.67-67: The update to the
command-line
property to include--port 80
aligns with the intent to deploy the application on the default HTTP port as described in the pull request.70-70: The
command-line
for the API deployment also correctly specifies port 80, ensuring consistency with the FE deployment and the overall intent to use the default HTTP port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/manual-deploy-obscuro-scan-3.yml (1 hunks)
Additional comments: 1
.github/workflows/manual-deploy-obscuro-scan-3.yml (1)
- 58-70: The changes to the
dns-name-label
andname
properties, as well as the update to thecommand-line
property, are consistent with the summary provided. The deployment configuration now correctly specifies port 80 for the application to listen on, aligning with the PR's goal to fix the port start issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- tools/obscuroscan_v3/frontend/package.json
Files selected for processing (1)
- .github/workflows/manual-deploy-obscuro-scan-3.yml (1 hunks)
Additional comments: 1
.github/workflows/manual-deploy-obscuro-scan-3.yml (1)
- 58-70: The changes to the
dns-name-label
,name
, andcommand-line
are consistent with the summary and pull request description. The application is configured to listen on port 80 as indicated by theports
field. Ensure that thenpm run start-prod
command is correctly configured to start the application on port 80.
Why this change is needed
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks