Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obscuroscan now deploys to port 80 #1675

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Obscuroscan now deploys to port 80 #1675

merged 4 commits into from
Nov 29, 2023

Conversation

otherview
Copy link
Contributor

Why this change is needed

  • Fixing the port start

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@otherview otherview requested a review from Jennievon November 29, 2023 14:13
Copy link

coderabbitai bot commented Nov 29, 2023

Walkthrough

The GitHub workflow file .github/workflows/manual-deploy-obscuro-scan-3.yml has been updated to reflect a new version, indicated by the -v3 suffix added to certain properties. Additionally, the command used to start the application has been modified to either include a new argument specifying the port or to change the npm script being run, suggesting a shift in how the application is deployed or started in its production environment.

Changes

File Change Summary
.github/.../manual-deploy-obscuro-scan-3.yml Updated dns-name-label and name with -v3 suffix; modified command-line to include --port 80 or change to npm run start-prod.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 3e9e4a8 and 6061b6f.
Files selected for processing (1)
  • .github/workflows/manual-deploy-obscuro-scan-3.yml (1 hunks)
Additional comments: 1
.github/workflows/manual-deploy-obscuro-scan-3.yml (1)
  • 58-70: The changes to the dns-name-label and name fields, as well as the addition of the --p80 argument in the command-line field, align with the summary. Verify that the --p80 flag is correctly implemented in the npm run start command to ensure the application listens on port 80 as intended.

Copy link
Contributor

@Jennievon Jennievon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 3e9e4a8 and 553948d.
Files selected for processing (1)
  • .github/workflows/manual-deploy-obscuro-scan-3.yml (1 hunks)
Additional comments: 3
.github/workflows/manual-deploy-obscuro-scan-3.yml (3)
  • 61-63: The addition of the "-v3" suffix to the dns-name-label and name properties is consistent with the versioning update mentioned in the summary.

  • 67-67: The update to the command-line property to include --port 80 aligns with the intent to deploy the application on the default HTTP port as described in the pull request.

  • 70-70: The command-line for the API deployment also correctly specifies port 80, ensuring consistency with the FE deployment and the overall intent to use the default HTTP port.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 553948d and 34296b0.
Files selected for processing (1)
  • .github/workflows/manual-deploy-obscuro-scan-3.yml (1 hunks)
Additional comments: 1
.github/workflows/manual-deploy-obscuro-scan-3.yml (1)
  • 58-70: The changes to the dns-name-label and name properties, as well as the update to the command-line property, are consistent with the summary provided. The deployment configuration now correctly specifies port 80 for the application to listen on, aligning with the PR's goal to fix the port start issue.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 34296b0 and 4b0d1cf.
Files ignored due to filter (1)
  • tools/obscuroscan_v3/frontend/package.json
Files selected for processing (1)
  • .github/workflows/manual-deploy-obscuro-scan-3.yml (1 hunks)
Additional comments: 1
.github/workflows/manual-deploy-obscuro-scan-3.yml (1)
  • 58-70: The changes to the dns-name-label, name, and command-line are consistent with the summary and pull request description. The application is configured to listen on port 80 as indicated by the ports field. Ensure that the npm run start-prod command is correctly configured to start the application on port 80.

@otherview otherview merged commit 362a80b into main Nov 29, 2023
2 of 3 checks passed
@otherview otherview deleted the pedro/next_deploy_fe branch November 29, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants