-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jennifer/ten gateway #1685
Jennifer/ten gateway #1685
Conversation
…bscuronet/go-obscuro into jennifer/ten-gateway
…nnifer/ten-gateway
…ol/go-ten into jennifer/ten-gateway
- refactor error handling - add loading state
- fix: remove conditional params
…nnifer/ten-gateway
…nnifer/ten-gateway
…nnifer/ten-gateway
…nnifer/ten-gateway
WalkthroughThe update involves a modification to the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- tools/walletextension/frontend/src/components/modules/common/network-status.tsx (1 hunks)
Additional comments: 2
tools/walletextension/frontend/src/components/modules/common/network-status.tsx (2)
10-13: The implementation correctly checks for the existence of
navigator
before accessingnavigator.onLine
to set the initialisOnline
state. This prevents potential runtime errors in environments wherenavigator
might be undefined.8-16: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [15-26]
The
useEffect
hook is set up correctly to handle online and offline events, ensuring that theisOnline
state is updated accordingly. The cleanup function properly removes the event listeners, which is important to prevent memory leaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, previous version did not build
Why this change is needed
Please provide a description and a link to the underlying ticket
fix build error occurring in network-status file
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks