-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change network name back to Obscuro Testnet, to avoid warnings #1695
Conversation
WalkthroughThe recent update involves renaming testnets within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- tools/walletextension/frontend/src/lib/constants.ts (2 hunks)
Additional comments: 3
tools/walletextension/frontend/src/lib/constants.ts (3)
14-19: The update to the
sepolia
object'sname
property to "Obscuro Testnet" aligns with the PR's objective to standardize the network name. Ensure that this change does not impact any functionality that relies on the network name.28-33: The update to the
default
object'sname
property to "Obscuro Testnet" is consistent with the PR's objective. Verify that this change is reflected wherever thedefault
network name is utilized.13-19: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [13-34]
Please confirm that the pre-merging PR checks have been completed as indicated by the checklist in the PR description. This is crucial to ensure that all necessary verifications are done before merging.
Why this change is needed
To avoid warnings from Metamask, caused by having different name for the network
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks