Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change network name back to Obscuro Testnet, to avoid warnings #1695

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Dec 12, 2023

Why this change is needed

To avoid warnings from Metamask, caused by having different name for the network

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@zkokelj zkokelj marked this pull request as ready for review December 12, 2023 09:03
Copy link

coderabbitai bot commented Dec 12, 2023

Walkthrough

The recent update involves renaming testnets within the constants.ts file of a wallet extension's frontend. The "Ten Dev-Testnet" and "Ten Testnet" have both been rebranded to "Obscuro Testnet". This change suggests a strategic move to unify the naming convention across different environments, possibly to align with a new branding strategy or to provide clearer differentiation between test networks.

Changes

File Path Change Summary
.../frontend/src/lib/constants.ts Updated the name property for sepolia and default objects from "Ten Dev-Testnet" and "Ten Testnet" to "Obscuro Testnet".

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment from CodeRabbit.
  • You can also chat with CodeRabbit bot directly around the specific lines of code or files in the PR by tagging @coderabbitai in a new comment.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c4c827d and 0457aa1.
Files selected for processing (1)
  • tools/walletextension/frontend/src/lib/constants.ts (2 hunks)
Additional comments: 3
tools/walletextension/frontend/src/lib/constants.ts (3)
  • 14-19: The update to the sepolia object's name property to "Obscuro Testnet" aligns with the PR's objective to standardize the network name. Ensure that this change does not impact any functionality that relies on the network name.

  • 28-33: The update to the default object's name property to "Obscuro Testnet" is consistent with the PR's objective. Verify that this change is reflected wherever the default network name is utilized.

  • 13-19: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [13-34]

Please confirm that the pre-merging PR checks have been completed as indicated by the checklist in the PR description. This is crucial to ensure that all necessary verifications are done before merging.

@zkokelj zkokelj merged commit 0f690c9 into main Dec 12, 2023
1 of 2 checks passed
@zkokelj zkokelj deleted the ziga/change_network_name_back_to_obscuro branch December 12, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants