Enclave: produce no batch if all tx failed

[BedrockSquirrel]

Why this change is needed

Avoid spamming empty batches when there is a rejected tx but no successful transactions.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

• PR checks reviewed and performed

[coderabbitai]

Walkthrough

The change involves a modification in the ComputeBatch method within a Go file related to enclave components. The update adjusts the condition that determines when a batch is ready to be computed. Previously, the batch would proceed if there were zero transactions to process, but after the change, it now checks if the number of transactions to process minus the number of excluded transactions equals zero, indicating an empty batch only when all transactions are excluded.

Changes

File	Summary
.../components/batch_executor.go	Modified the condition in ComputeBatch method to check if the number of transactions to process minus excluded transactions is zero.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7c2a4df and 438222a.

Files selected for processing (1)

• go/enclave/components/batch_executor.go (1 hunks)

Additional comments: 1

go/enclave/components/batch_executor.go (1)

• 213-219: The updated condition in the ComputeBatch method correctly implements the PR's objective by ensuring that a batch is only created if there are transactions to process after excluding the failed ones. This is a logical and efficient way to prevent the creation of empty batches.

[coderabbitai]

Consider refactoring the ComputeBatch method to reduce its cognitive complexity and improve maintainability. This could involve breaking down the method into smaller, more focused sub-methods.

[tudor-malene]

lgtm.

this is probably it.
I'm working on getting rid of that excluded txs thing