Testnet Deployments: set enclave TESTMODE=true

[BedrockSquirrel]

Why this change is needed

Testnet deployments and upgrades are currently failing because the enclave docker image is set to TESTMODE=false (the default).

This means it expects to find required flags from enclave.json but they're not there so it panics.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

• PR checks reviewed and performed

[coderabbitai]

Walkthrough

The changes involve the addition of a build argument TESTMODE=true to the Docker build commands in two GitHub workflow files. This argument is specified for the construction of obscuro node images, potentially altering the build and testing behavior of the enclave images within the continuous integration process.

Changes

File Path	Change Summary
.github/workflows/.../manual-deploy-testnet-l2.yml	Added --build-arg TESTMODE=true to the docker build command for enclave images.
.github/workflows/.../manual-upgrade-testnet-l2.yml	Added --build-arg TESTMODE=true to the docker build command for the L2_ENCLAVE_DOCKER_BUILD_TAG image.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between ecf49b1 and ef6ead2.

Files selected for processing (2)

• .github/workflows/manual-deploy-testnet-l2.yml (1 hunks)
• .github/workflows/manual-upgrade-testnet-l2.yml (1 hunks)

Files skipped from review due to trivial changes (1)

• .github/workflows/manual-upgrade-testnet-l2.yml

Additional comments: 3

.github/workflows/manual-deploy-testnet-l2.yml (3)

• 70-70: The addition of --build-arg TESTMODE=true to the docker build command for the enclave image aligns with the PR's objective to resolve issues with testnet deployments. This change should enable test mode during the build, which is necessary for successful testnet deployments and upgrades.

• 67-73: It's important to verify that the addition of the TESTMODE build argument does not interfere with any other steps or dependencies in the build process. This includes checking for any scripts or configurations that might behave differently when the enclave is in test mode.

Verification successful

---

Based on the references found in the codebase, the addition of TESTMODE=true in the GitHub workflow files appears to be consistent with the existing usage of the TESTMODE variable in Dockerfiles, testnet configurations, and Go source code. The Docker build process is designed to handle the TESTMODE argument, and the change aligns with the PR's objective to enable test mode for testnet deployments.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Check for any references to TESTMODE in scripts or configurations that might behave differently when the enclave is in test mode.
rg --files-with-matches 'TESTMODE' | xargs rg 'TESTMODE'

Length of output: 774

* 67-73: Ensure that the procedural checklist item for pre-merging PR checks is completed by the developer as outlined in the project's documentation. This is a non-code related but essential step in the PR process.

[tudor-malene]

lgtm