Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tenscan] fix latest batch #1704

Merged
merged 6 commits into from
Jan 8, 2024
Merged

[Tenscan] fix latest batch #1704

merged 6 commits into from
Jan 8, 2024

Conversation

Jennievon
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

What changes were made as part of this PR

Please provide a high level list of the changes made

fix latest batch

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

- no MM loading screen
- fetch connected accounts on reload
@Jennievon Jennievon requested a review from zkokelj December 15, 2023 09:40
@Jennievon Jennievon self-assigned this Dec 15, 2023
Copy link

coderabbitai bot commented Dec 15, 2023

Walkthrough

The change involves updating a component in the Dashboard to conditionally display the latest Layer 2 (L2) batch number. If the batch number is available, it is shown; otherwise, "N/A" is displayed. This ensures that the dashboard gracefully handles situations where the latest batch number might be missing, maintaining a clean and informative UI.

Changes

File Path Change Summary
tools/obscuroscan_v3/frontend/src/components/modules/dashboard/index.tsx Modified the logic to use the latestBatch item's number as the value for "Latest L2 Batch" if it exists, otherwise defaulting to "N/A".

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Base automatically changed from jennifer/fix-non-mm-screen to main December 15, 2023 11:10
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b528fcb and 9a4c2cb.
Files selected for processing (1)
  • tools/obscuroscan_v3/frontend/src/components/modules/dashboard/index.tsx (1 hunks)
Additional comments: 1
tools/obscuroscan_v3/frontend/src/components/modules/dashboard/index.tsx (1)
  • 46-54: The commented TODO items indicate future work that has not been completed. Ensure that these comments are tracked in the project's task management system to avoid losing track of them.

@Jennievon Jennievon requested a review from otherview December 19, 2023 11:36
Copy link
Contributor

@zkokelj zkokelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9a4c2cb and 558e9c6.
Files selected for processing (1)
  • tools/tenscan/frontend/src/components/modules/dashboard/index.tsx (1 hunks)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 558e9c6 and 573def7.
Files selected for processing (1)
  • tools/tenscan/frontend/src/components/modules/dashboard/index.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • tools/tenscan/frontend/src/components/modules/dashboard/index.tsx

@Jennievon Jennievon merged commit 8d534c0 into main Jan 8, 2024
2 checks passed
@Jennievon Jennievon deleted the jennifer/fix-latest-batch branch January 8, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants