Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set retention to 7 days for deployer logs #1706

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

moraygrieve
Copy link
Contributor

@moraygrieve moraygrieve commented Dec 19, 2023

Why this change is needed

On an L2 deploy the deployer logs are the only way to get all of the L1 and L2 contract addresses at the moment. On a new deploy the e2e tests need the new addresses to be able to run all tests. With a retention of 1 day, should a redeploy happen over the holidays the addresses may be lost, or difficult to access. As they are of very small size, increasing the retention to 7 days should not affect our git disk utilisation.

Copy link

coderabbitai bot commented Dec 19, 2023

Walkthrough

The update involves a single YAML configuration file used for GitHub workflows related to deploying artifacts on a testnet. Specifically, the retention-days for logs of two jobs within the workflow have been increased from 1 day to 7 days, allowing logs to be kept for a longer period.

Changes

File Changes
.github/workflows/.../manual-deploy-... Updated retention-days from 1 to 7 for two jobs: deploy-l1-artifacts and deploy-l2-artifacts.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b528fcb and 1b54d5e.
Files selected for processing (1)
  • .github/workflows/manual-deploy-testnet-l2.yml (2 hunks)
Additional comments: 3
.github/workflows/manual-deploy-testnet-l2.yml (3)
  • 118-121: The change from retention-days: 1 to retention-days: 7 for deploy-l1-artifacts aligns with the PR's objective to extend the log retention period for deployer logs, ensuring that contract addresses remain accessible for e2e tests.

  • 324-327: The update from retention-days: 1 to retention-days: 7 for deploy-l2-artifacts is consistent with the PR's goal to increase the availability of deployer logs for e2e tests after deployments.

  • 118-124: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [118-327]

The modifications are confined to the GitHub Actions workflow configuration and do not impact any exported or public entities. This is in line with the AI-generated summary and the PR's stated objectives.

@moraygrieve moraygrieve merged commit 4ee0cca into main Dec 19, 2023
1 of 2 checks passed
@moraygrieve moraygrieve deleted the moray/retention_on_deploy_l2 branch December 19, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants