-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build #1721
Fix build #1721
Changes from 7 commits
60a45ee
e79e913
3792c75
7aaafdd
fdb8c05
57dcce5
a58c598
d12a540
30f5fd8
3bde2ac
6f9c00e
c540313
7bad38d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,18 +2,18 @@ package integration | |
|
||
// Tracks the start ports handed out to different tests, in a bid to minimise conflicts. | ||
const ( | ||
StartPortEth2NetworkTests = 31000 | ||
StartPortNodeRunnerTest = 32000 | ||
StartPortSimulationGethInMem = 34000 | ||
StartPortSimulationInMem = 35000 | ||
StartPortSimulationFullNetwork = 37000 | ||
StartPortSmartContractTests = 38000 | ||
StartPortContractDeployerTest = 39000 | ||
StartPortWalletExtensionUnitTest = 40000 | ||
StartPortFaucetUnitTest = 41000 | ||
StartPortFaucetHTTPUnitTest = 42000 | ||
StartPortTenscanUnitTest = 43000 | ||
StartPortTenGatewayUnitTest = 44000 | ||
StartPortEth2NetworkTests = 10000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the reason we need to change ports? Were there conflicts? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that's right. There are still conflicts in ports, although less now. I've also added a log to tell us which process is occupying the conflicting port. |
||
StartPortNodeRunnerTest = 14000 | ||
StartPortSimulationGethInMem = 18000 | ||
StartPortSimulationInMem = 22000 | ||
StartPortSimulationFullNetwork = 26000 | ||
StartPortSmartContractTests = 30000 | ||
StartPortContractDeployerTest = 34000 | ||
StartPortWalletExtensionUnitTest = 38000 | ||
StartPortFaucetUnitTest = 42000 | ||
StartPortFaucetHTTPUnitTest = 48000 | ||
StartPortTenscanUnitTest = 52000 | ||
StartPortTenGatewayUnitTest = 56000 | ||
|
||
DefaultGethWSPortOffset = 100 | ||
DefaultGethAUTHPortOffset = 200 | ||
|
@@ -24,9 +24,9 @@ const ( | |
DefaultEnclaveOffset = 700 // The default offset between a Geth nodes port and the enclave ports. Used in Socket Simulations. | ||
DefaultHostRPCHTTPOffset = 800 // The default offset for the host's RPC HTTP port | ||
DefaultHostRPCWSOffset = 900 // The default offset for the host's RPC websocket port | ||
DefaultTenscanHTTPPortOffset = 910 | ||
DefaultTenGatewayHTTPPortOffset = 930 | ||
DefaultTenGatewayWSPortOffset = 940 | ||
DefaultTenscanHTTPPortOffset = 1000 | ||
DefaultTenGatewayHTTPPortOffset = 1001 | ||
DefaultTenGatewayWSPortOffset = 1002 | ||
) | ||
|
||
const ( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -227,7 +227,7 @@ func (s *Simulation) deployObscuroERC20s() { | |
|
||
deployContractTx := types.DynamicFeeTx{ | ||
Nonce: NextNonce(s.ctx, s.RPCHandles, owner), | ||
Gas: 2_000_000, | ||
Gas: 5_000_000, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the reason for increasing gas here, while decreasing it in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just making the gas limit equal everywhere pretty much. |
||
GasFeeCap: gethcommon.Big1, // This field is used to derive the gas price for dynamic fee transactions. | ||
Data: contractBytes, | ||
GasTipCap: gethcommon.Big1, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it now set to 40 M, while
GasBatchExecutionLimit
is 30M?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might have a bug somewhere, but it seems like if the GasLocalExecutionCapFlag <= GasBatchExecutionLimit we get more flaky errors, so I ended up bumping the local execution max gas to more than the batch size.