Tenscan workflow #1724
Tenscan workflow #1724
Conversation
WalkthroughThe GitHub workflow for deploying the Tenscan Testnet has undergone a rebranding from its previous version 3. The naming conventions have been streamlined to reflect the updated branding, affecting the workflow's name, run-name, Docker build paths, and Azure Container Instances configuration. The changes indicate a shift from "obscuroscan_v3" to a simpler "tenscan" nomenclature, likely to align with a new version or branding strategy. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/manual-deploy-ten-scan.yml (3 hunks)
Additional comments: 5
.github/workflows/manual-deploy-ten-scan.yml (5)
4-5: The workflow name and run-name have been updated to reflect the new Tenscan branding. This change is consistent with the PR objectives and AI-generated summary.
61-61: The DNS name label for the frontend service in Azure Container Instances has been updated to include 'ten-scan'. Confirm that this new DNS name label is correctly configured in Azure and does not conflict with existing services.
63-63: The instance name for the frontend service in Azure Container Instances has been updated to include 'ten-scan'. Verify that this new instance name is unique and does not cause conflicts with existing instances.
76-76: The DNS name label for the backend API service in Azure Container Instances has been updated to include 'api-ten-scan'. As with the frontend, ensure that this new DNS name label is correctly configured and does not overlap with other services.
78-78: The instance name for the backend API service in Azure Container Instances has been updated to include 'api-ten-scan'. Confirm that this new instance name is properly unique within the Azure environment.
| @@ -46,21 +46,21 @@ jobs: | |||
|
|
|||
| - name: Build and Push Docker FE Image | |||
| run: | | |||
| DOCKER_BUILDKIT=1 docker build -t ${{ vars.DOCKER_BUILD_TAG_SCAN_FE }} -f ./tools/obscuroscan_v3/frontend/Dockerfile . | |||
| DOCKER_BUILDKIT=1 docker build -t ${{ vars.DOCKER_BUILD_TAG_SCAN_FE }} -f ./tools/tenscan/frontend/Dockerfile . | |||
There was a problem hiding this comment.
💡 NOTE
Codebase verification is a beta feature.
The verification script has confirmed that the Dockerfile for the frontend does not exist at the specified path ./tools/tenscan/frontend/Dockerfile. This indicates an issue with the updated Docker build path in the pull request.
- : The Docker build path for the frontend in the
.github/workflows/manual-deploy-ten-scan.ymlfile points to a non-existentDockerfileat./tools/tenscan/frontend/Dockerfile.
Analysis chain
The Dockerfile path for the frontend image build has been updated to the new tenscan directory. Ensure that the new path is correct and the Dockerfile exists at this location.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the existence of the frontend Dockerfile in the tenscan directory.
fd Dockerfile --exec test -f ./tools/tenscan/frontend/Dockerfile
Length of output: 462
Script:
#!/bin/bash
# Corrected script to verify the existence of the frontend Dockerfile in the tenscan directory.
if [ -f "./tools/tenscan/frontend/Dockerfile" ]; then
echo "Frontend Dockerfile exists."
else
echo "Frontend Dockerfile does not exist."
fi
Length of output: 129
| docker push ${{ vars.DOCKER_BUILD_TAG_SCAN_FE }} | ||
|
|
||
| - name: Build and Push Docker API Image | ||
| run: | | ||
| DOCKER_BUILDKIT=1 docker build -t ${{ vars.DOCKER_BUILD_TAG_SCAN_API }} -f ./tools/obscuroscan_v2/backend/Dockerfile . | ||
| DOCKER_BUILDKIT=1 docker build -t ${{ vars.DOCKER_BUILD_TAG_SCAN_API }} -f ./tools/tenscan/backend/Dockerfile . |
There was a problem hiding this comment.
💡 NOTE
Codebase verification is a beta feature.
The verification process has confirmed that the backend Dockerfile does not exist at the specified path ./tools/tenscan/backend/Dockerfile. This information should be communicated to the user.
- The Dockerfile for the backend in the
tenscandirectory does not exist.
Analysis chain
The Dockerfile path for the backend image build has been updated to the new tenscan directory. Similar to the frontend Dockerfile, verify that the Dockerfile for the backend exists at the specified path.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the existence of the backend Dockerfile in the tenscan directory.
fd Dockerfile --exec test -f ./tools/tenscan/backend/Dockerfile
Length of output: 461
Script:
#!/bin/bash
# Find the Dockerfile in the tenscan/backend directory and verify its existence.
fd Dockerfile ./tools/tenscan/backend/ | xargs -I {} test -f {} && echo "Dockerfile exists" || echo "Dockerfile does not exist"
Length of output: 226
Script:
#!/bin/bash
# Directly check for the existence of the backend Dockerfile in the tenscan directory.
if [ -f ./tools/tenscan/backend/Dockerfile ]; then
echo "Backend Dockerfile exists."
else
echo "Backend Dockerfile does not exist."
fi
Length of output: 126
Why this change is needed
As per title - required to merge in first so we can test the deployments.
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks