Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Testnet start #1725

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Fix Testnet start #1725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions go/enclave/components/batch_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func (executor *batchExecutor) ComputeBatch(context *BatchExecutionContext, fail
if err != nil {
return nil, fmt.Errorf("could not create stateDB. Cause: %w", err)
}
snap := stateDB.Snapshot()
// snap := stateDB.Snapshot()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code can lead to confusion and should be accompanied by a clear explanation or a linked issue for context.

- // snap := stateDB.Snapshot()
+ // TODO: Re-enable stateDB.Snapshot() once issue #2654 is resolved.
Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
// snap := stateDB.Snapshot()
// TODO: Re-enable stateDB.Snapshot() once issue #2654 is resolved.


var messages common.CrossChainMessages
var transfers common.ValueTransferEvents
Expand Down Expand Up @@ -222,8 +222,9 @@ func (executor *batchExecutor) ComputeBatch(context *BatchExecutionContext, fail
len(crossChainTransactions) == 0 &&
len(messages) == 0 &&
len(transfers) == 0 {
// revert any unexpected mutation to the statedb
stateDB.RevertToSnapshot(snap)
// todo review why this is failing deployment with "panic: revision id 0 cannot be reverted" - https://github.com/ten-protocol/ten-internal/issues/2654
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment regarding the deployment failure should include a reference to the issue tracker for easier follow-up.

+ // TODO: Review the cause of "panic: revision id 0 cannot be reverted" and resolve it according to issue #2654.
Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
// todo review why this is failing deployment with "panic: revision id 0 cannot be reverted" - https://github.com/ten-protocol/ten-internal/issues/2654
// TODO: Review the cause of "panic: revision id 0 cannot be reverted" and resolve it according to issue #2654.

//// revert any unexpected mutation to the statedb
//stateDB.RevertToSnapshot(snap)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the revert state functionality may have implications for the state consistency. Ensure that the risks are understood and that there is a plan to re-enable this functionality.

- //stateDB.RevertToSnapshot(snap)
+ // FIXME: Re-enable stateDB.RevertToSnapshot(snap) once the underlying issue is resolved.
Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
//stateDB.RevertToSnapshot(snap)
// FIXME: Re-enable stateDB.RevertToSnapshot(snap) once the underlying issue is resolved.

return nil, ErrNoTransactionsToProcess
}

Expand Down
Loading