-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change tenscan link in gateway and docs #1726
Conversation
WalkthroughThe recent updates involve ensuring secure access to TenScan, a blockchain explorer, by changing the URLs from HTTP to HTTPS protocol. This enhances user security and privacy. Additionally, a constant in the wallet extension's codebase has been updated to reflect this change, potentially altering how the extension interacts with TenScan. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- docs/_docs/testnet/example-dapps.md (1 hunks)
- docs/_docs/testnet/obscuroscan.md (1 hunks)
- tools/walletextension/frontend/src/lib/constants.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- docs/_docs/testnet/example-dapps.md
- docs/_docs/testnet/obscuroscan.md
Additional comments: 1
tools/walletextension/frontend/src/lib/constants.ts (1)
- 4-4: The update of
tenscanLink
from a testnet URL to the production URL "https://tenscan.io/" is noted. Ensure that this change is reflected across all user-facing components where the TenScan link is utilized.Verification successful
The update of the
tenscanLink
constant to "https://tenscan.io/" has been successfully reflected in the codebase, specifically within theethRequests.ts
file where it is used. No issues were found related to this change.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that the updated tenscanLink is not causing issues in the places it's used. rg --type ts "tenscanLink" --files-with-matches | xargs -L1 ast-grep --lang typescript --pattern '$_ = "https://tenscan.io/"'Length of output: 125
Script:
#!/bin/bash # Search for the usage of tenscanLink throughout the TypeScript files. rg --type ts "tenscanLink"Length of output: 295
e7c957b
to
195bf4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- docs/_docs/testnet/example-dapps.md (1 hunks)
- docs/_docs/testnet/obscuroscan.md (1 hunks)
- tools/walletextension/frontend/src/lib/constants.ts (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- docs/_docs/testnet/example-dapps.md
- docs/_docs/testnet/obscuroscan.md
- tools/walletextension/frontend/src/lib/constants.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
195bf4b
to
c4f7ea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- docs/_docs/testnet/example-dapps.md (1 hunks)
- docs/_docs/testnet/obscuroscan.md (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- docs/_docs/testnet/example-dapps.md
- docs/_docs/testnet/obscuroscan.md
Why this change is needed
Previous link was not working.
It was reported by users
https://discord.com/channels/916052669955727371/930433726792470568/1189848417145466921
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks