Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change tenscan link in gateway and docs #1726

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Dec 28, 2023

Why this change is needed

Previous link was not working.

It was reported by users
https://discord.com/channels/916052669955727371/930433726792470568/1189848417145466921

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link

coderabbitai bot commented Dec 28, 2023

Walkthrough

The recent updates involve ensuring secure access to TenScan, a blockchain explorer, by changing the URLs from HTTP to HTTPS protocol. This enhances user security and privacy. Additionally, a constant in the wallet extension's codebase has been updated to reflect this change, potentially altering how the extension interacts with TenScan.

Changes

Files Change Summary
docs/_docs/testnet/.../example-dapps.md Updated URLs to use https://testnet.tenscan.io/
docs/_docs/testnet/.../obscuroscan.md Updated URLs to use https://testnet.tenscan.io
tools/walletextension/.../constants.ts Updated tenscanLink constant to https://tenscan.io

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@zkokelj zkokelj marked this pull request as ready for review December 28, 2023 08:41
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b6444cf and e7c957b.
Files selected for processing (3)
  • docs/_docs/testnet/example-dapps.md (1 hunks)
  • docs/_docs/testnet/obscuroscan.md (1 hunks)
  • tools/walletextension/frontend/src/lib/constants.ts (1 hunks)
Files skipped from review due to trivial changes (2)
  • docs/_docs/testnet/example-dapps.md
  • docs/_docs/testnet/obscuroscan.md
Additional comments: 1
tools/walletextension/frontend/src/lib/constants.ts (1)
  • 4-4: The update of tenscanLink from a testnet URL to the production URL "https://tenscan.io/" is noted. Ensure that this change is reflected across all user-facing components where the TenScan link is utilized.
Verification successful

The update of the tenscanLink constant to "https://tenscan.io/" has been successfully reflected in the codebase, specifically within the ethRequests.ts file where it is used. No issues were found related to this change.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify that the updated tenscanLink is not causing issues in the places it's used.
rg --type ts "tenscanLink" --files-with-matches | xargs -L1 ast-grep --lang typescript --pattern '$_ = "https://tenscan.io/"'

Length of output: 125



Script:

#!/bin/bash
# Search for the usage of tenscanLink throughout the TypeScript files.
rg --type ts "tenscanLink"

Length of output: 295

@zkokelj zkokelj force-pushed the ziga/update_tenscan_link_in_gateway branch from e7c957b to 195bf4b Compare December 28, 2023 08:44
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b6444cf and 195bf4b.
Files selected for processing (3)
  • docs/_docs/testnet/example-dapps.md (1 hunks)
  • docs/_docs/testnet/obscuroscan.md (1 hunks)
  • tools/walletextension/frontend/src/lib/constants.ts (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • docs/_docs/testnet/example-dapps.md
  • docs/_docs/testnet/obscuroscan.md
  • tools/walletextension/frontend/src/lib/constants.ts

Copy link
Contributor

@Jennievon Jennievon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

change tenscan link
@zkokelj zkokelj force-pushed the ziga/update_tenscan_link_in_gateway branch from 195bf4b to c4f7ea1 Compare December 28, 2023 10:23
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b6444cf and c4f7ea1.
Files selected for processing (2)
  • docs/_docs/testnet/example-dapps.md (1 hunks)
  • docs/_docs/testnet/obscuroscan.md (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • docs/_docs/testnet/example-dapps.md
  • docs/_docs/testnet/obscuroscan.md

@moraygrieve moraygrieve merged commit 010815f into main Jan 2, 2024
1 check passed
@moraygrieve moraygrieve deleted the ziga/update_tenscan_link_in_gateway branch January 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants