[network-tests] Update UAT config #1731
Conversation
WalkthroughThe recent update in the codebase reflects a shift in naming convention and endpoint URLs for the testnet environment. Specifically, the testnet is now referred to as the UAT (User Acceptance Testing) Testnet, indicating a more focused stage of testing. Correspondingly, the URLs for accessing the testnet's faucet and Ethereum 2 network have been updated to match this new naming scheme, ensuring consistency across the testing infrastructure. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
BedrockSquirrel
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- integration/networktest/env/network_setup.go (1 hunks)
Additional comments: 2
integration/networktest/env/network_setup.go (2)
- 18-26: Ensure that all references to the old
Testnetfunction have been updated toUATTestnetacross the codebase.Verification successful
To verify if the occurrences of
Testnet()inavailability_test.goandrunner.goare references to the oldTestnetfunction or if they are separate functions, we can useast-grepto check the context of these functions within their respective classes.
To better understand the context of
Testnet()usage inavailability_test.goandrunner.go, we will usergto get the surrounding code for these occurrences.
The review of the new context reveals the following:
- In
availability_test.go, the functionDevTestnet()is being used, notTestnet().- In
runner.go, the reference toDevTestnet()is in a commented-out example usage, which is not an executable part of the code.Therefore, there are no remaining references to a
Testnet()function that would need to be updated toUATTestnet(). The initial concern about updating all references to the oldTestnetfunction across the codebase has been addressed.* 22-23: Confirm that the new URLs for the UAT testnet faucet and WebSocket connection are reachable and correctly configured.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search to find files that import network_setup module. Expecting list of dependent files. rg -C3 --type go $'import .+network_setup' # Search old function name to find omissions. Expecting no results. rg --type go $'Testnet\(' # Search new function name to validate usage. Expecting list of locations where the new function name is used. rg --type go $'UATTestnet\('Length of output: 632
Script:
#!/bin/bash # Check the context of `Testnet()` function in `availability_test.go` ast-grep --lang go --pattern $'func $_() $_ { $$$ Testnet($_) $$$ }' integration/networktest/tests/helpful/availability_test.go # Check the context of `Testnet()` function in `runner.go` ast-grep --lang go --pattern $'func $_() $_ { $$$ Testnet($_) $$$ }' integration/networktest/runner.goLength of output: 244
Script:
#!/bin/bash # Get surrounding code for `Testnet()` occurrence in `availability_test.go` rg --context 5 --type go 'Testnet\(' integration/networktest/tests/helpful/availability_test.go # Get surrounding code for `Testnet()` occurrence in `runner.go` rg --context 5 --type go 'Testnet\(' integration/networktest/runner.goLength of output: 1106
Why this change is needed
Update networktest environment Testnet -> UAT Testnet config.
Have verified this config with availability_test and smoke_test.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks