Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change network name #1735

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Change network name #1735

merged 2 commits into from
Jan 9, 2024

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Jan 6, 2024

Why this change is needed

To avoid warning when adding new network & possibly fix errors getting correct balances

What changes were made as part of this PR

Update network name

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link

coderabbitai bot commented Jan 6, 2024

Walkthrough

The recent update involves renaming a testnet within the project's constants file. This alteration reflects a change in the designation of the testnet from "Obscuro Testnet" to "Ten Testnet," likely to align with rebranding or a shift in the network's development or deployment strategy.

Changes

File Path Change Summary
.../frontend/src/lib/constants.ts Renamed "Obscuro Testnet" to "Ten Testnet."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@zkokelj zkokelj marked this pull request as ready for review January 6, 2024 13:56
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b6dada7 and 368ebda.
Files selected for processing (1)
  • tools/walletextension/frontend/src/lib/constants.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • tools/walletextension/frontend/src/lib/constants.ts

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 368ebda and caf34a5.
Files selected for processing (1)
  • tools/walletextension/frontend/src/lib/constants.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • tools/walletextension/frontend/src/lib/constants.ts

@zkokelj zkokelj temporarily deployed to sepolia-testnet January 6, 2024 14:04 — with GitHub Actions Inactive
Copy link
Contributor

@GavT GavT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@zkokelj zkokelj merged commit 3103eca into main Jan 9, 2024
2 of 3 checks passed
@zkokelj zkokelj deleted the ziga/rename_metamask_network_name branch January 9, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants