-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mempool Perf fix #1752
Merged
Merged
Mempool Perf fix #1752
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7327bb0
perf
tudor-malene 171fdc8
chain the converted geth chain properly
tudor-malene aa57c0c
fix edgless script
tudor-malene 0098052
various perf fixes
tudor-malene 352ffba
test
tudor-malene 5538ec5
small fixes
tudor-malene 94e603c
address PR comments
tudor-malene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package common | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/eko/gocache/lib/v4/cache" | ||
| gethlog "github.com/ethereum/go-ethereum/log" | ||
| "github.com/ten-protocol/go-ten/go/common/log" | ||
| ) | ||
|
|
||
| // GetCachedValue - returns the cached value for the provided key. If the key is not found, then invoke the 'onFailed' function | ||
| // which returns the value, and cache it | ||
| func GetCachedValue[V any](cache *cache.Cache[V], logger gethlog.Logger, key any, onFailed func(any) (V, error)) (V, error) { | ||
| value, err := cache.Get(context.Background(), key) | ||
| if err != nil { | ||
| // todo metrics for cache misses | ||
| b, err := onFailed(key) | ||
| if err != nil { | ||
| return b, err | ||
| } | ||
| CacheValue(cache, logger, key, b) | ||
| return b, err | ||
| } | ||
|
|
||
| return value, err | ||
| } | ||
|
|
||
| func CacheValue[V any](cache *cache.Cache[V], logger gethlog.Logger, key any, v V) { | ||
| err := cache.Set(context.Background(), key, v) | ||
| if err != nil { | ||
| logger.Error("Could not store value in cache", log.ErrKey, err) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
CacheValuefunction stores a value in the cache and logs an error if it fails. The error handling is correct, but it might be beneficial to consider whether the error should be returned to the caller instead of just logged.Consider returning the error from
CacheValueto allow the caller to handle it as needed.