Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedro/releases/v0.20 geth #1771

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

otherview
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link

coderabbitai bot commented Feb 2, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

This update encompasses a broad range of modifications aimed at improving system performance, reliability, and maintainability. Key changes include updates to Docker base images for compatibility with Alpine version 3.18, enhancements in logging and error handling within the enclave components, adjustments in transaction processing and storage mechanisms, and the introduction of new testing tools and configurations for frontend development. These alterations are designed to refine the system's operational efficiency and developer experience.

Changes

File(s) Change Summary
.github/workflows/manual-deploy-testnet-l2.yml Updated job dependencies and artifact retention days.
dockerfiles/.../enclave.debug.Dockerfile, dockerfiles/.../host.Dockerfile, tools/.../Dockerfile, tools/walletextension/Dockerfile Updated base images to golang:1.20-alpine3.18 and alpine:3.18.
go/common/headers.go, go/enclave/components/..., go/enclave/l2chain/l1_blockchain.go, go/enclave/nodetype/sequencer.go, go/enclave/txpool/txpool.go Enhanced logging, error handling, and transaction processing. Added new fields and adjusted data structures.
go/enclave/storage/..., go/enclave/storage/init/edgelessdb/edgelessdb.go Modified SQL queries and database configurations.
integration/..., tools/tenscan/frontend/... Added new functions, tests, and configurations for frontend development tools and integration testing.
tenscan_logs.txt Logged information about tenscan operations.

This table groups files by their type or area of change, summarizing the updates made across different parts of the system for clarity and conciseness.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@otherview otherview changed the base branch from main to releases/v0.20 February 2, 2024 01:38
Comment on lines 3 to 8
* ATTENTION: An "eval-source-map" devtool has been used.
* This devtool is neither made for production nor for readable output files.
* It uses "eval()" calls to create a separate source file with attached SourceMaps in the browser devtools.
* If you are trying to read the output file, select a different devtool (https://webpack.js.org/configuration/devtool/)
* or disable the default devtool with "devtool: false".
* If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of "eval-source-map" in production files is discouraged due to performance and security reasons. Consider using a different devtool for production builds to enhance security and efficiency.

Comment on lines 1 to 8
/*
* ATTENTION: An "eval-source-map" devtool has been used.
* This devtool is neither made for production nor for readable output files.
* It uses "eval()" calls to create a separate source file with attached SourceMaps in the browser devtools.
* If you are trying to read the output file, select a different devtool (https://webpack.js.org/configuration/devtool/)
* or disable the default devtool with "devtool: false".
* If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/).
*/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of "eval-source-map" for the devtool in a production build is discouraged due to performance and security reasons. Consider using a more production-appropriate source map type for minimizing and debugging production builds efficiently.

- * ATTENTION: An "eval-source-map" devtool has been used.
+ * Consider using a more production-appropriate source map type for production builds.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
/*
* ATTENTION: An "eval-source-map" devtool has been used.
* This devtool is neither made for production nor for readable output files.
* It uses "eval()" calls to create a separate source file with attached SourceMaps in the browser devtools.
* If you are trying to read the output file, select a different devtool (https://webpack.js.org/configuration/devtool/)
* or disable the default devtool with "devtool: false".
* If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/).
*/
/*
* Consider using a more production-appropriate source map type for production builds.
* This devtool is neither made for production nor for readable output files.
* It uses "eval()" calls to create a separate source file with attached SourceMaps in the browser devtools.
* If you are trying to read the output file, select a different devtool (https://webpack.js.org/configuration/devtool/)
* or disable the default devtool with "devtool: false".
* If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/).
*/

tenscan_logs.txt Outdated
Comment on lines 1 to 3
INFO [01-10|17:16:38.878] Created Obscuro Scan with the following: component=tenscan args="&{NodeHostAddress:http://erpc.dev-testnet.ten.xyz:80 ServerAddress:0.0.0.0:80 LogPath:tenscan_logs.txt}"
INFO [01-10|17:16:38.881] Starting server on 0.0.0.0:80 component=tenscan
ERROR[01-10|17:26:29.586] unable to execute request Post "http://erpc.dev-testnet.ten.xyz:80": read tcp 192.168.1.104:50252->51.11.135.65:80: read: operation timed out component=tenscan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tenscan_logs.txt file logs indicate successful server startup and an error related to a timed-out operation. Ensure error handling is robust and consider implementing retry logic or alerting mechanisms for critical failures.

+ // Consider adding retry logic for timed-out operations
+ // Implement alerting for critical errors

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
INFO [01-10|17:16:38.878] Created Obscuro Scan with the following: component=tenscan args="&{NodeHostAddress:http://erpc.dev-testnet.ten.xyz:80 ServerAddress:0.0.0.0:80 LogPath:tenscan_logs.txt}"
INFO [01-10|17:16:38.881] Starting server on 0.0.0.0:80 component=tenscan
ERROR[01-10|17:26:29.586] unable to execute request Post "http://erpc.dev-testnet.ten.xyz:80": read tcp 192.168.1.104:50252->51.11.135.65:80: read: operation timed out component=tenscan
INFO [01-10|17:16:38.878] Created Obscuro Scan with the following: component=tenscan args="&{NodeHostAddress:http://erpc.dev-testnet.ten.xyz:80 ServerAddress:0.0.0.0:80 LogPath:tenscan_logs.txt}"
INFO [01-10|17:16:38.881] Starting server on 0.0.0.0:80 component=tenscan
ERROR[01-10|17:26:29.586] unable to execute request Post "http://erpc.dev-testnet.ten.xyz:80": read tcp 192.168.1.104:50252->51.11.135.65:80: read: operation timed out component=tenscan
// Consider adding retry logic for timed-out operations
// Implement alerting for critical errors

@BedrockSquirrel BedrockSquirrel force-pushed the pedro/releases/v0.20_geth branch from 8e9c62c to b6ebcd9 Compare February 2, 2024 08:58
@BedrockSquirrel
Copy link
Collaborator

Replayed your commit Pedro but with the tenscan stuff removed.

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to be working in sepolia

@BedrockSquirrel BedrockSquirrel merged commit 2806f0e into releases/v0.20 Feb 2, 2024
1 check passed
@BedrockSquirrel BedrockSquirrel deleted the pedro/releases/v0.20_geth branch February 2, 2024 09:09
BedrockSquirrel pushed a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants