-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pedro/releases/v0.20 geth #1771
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThis update encompasses a broad range of modifications aimed at improving system performance, reliability, and maintainability. Key changes include updates to Docker base images for compatibility with Alpine version 3.18, enhancements in logging and error handling within the enclave components, adjustments in transaction processing and storage mechanisms, and the introduction of new testing tools and configurations for frontend development. These alterations are designed to refine the system's operational efficiency and developer experience. Changes
This table groups files by their type or area of change, summarizing the updates made across different parts of the system for clarity and conciseness. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
* ATTENTION: An "eval-source-map" devtool has been used. | ||
* This devtool is neither made for production nor for readable output files. | ||
* It uses "eval()" calls to create a separate source file with attached SourceMaps in the browser devtools. | ||
* If you are trying to read the output file, select a different devtool (https://webpack.js.org/configuration/devtool/) | ||
* or disable the default devtool with "devtool: false". | ||
* If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of "eval-source-map"
in production files is discouraged due to performance and security reasons. Consider using a different devtool for production builds to enhance security and efficiency.
/* | ||
* ATTENTION: An "eval-source-map" devtool has been used. | ||
* This devtool is neither made for production nor for readable output files. | ||
* It uses "eval()" calls to create a separate source file with attached SourceMaps in the browser devtools. | ||
* If you are trying to read the output file, select a different devtool (https://webpack.js.org/configuration/devtool/) | ||
* or disable the default devtool with "devtool: false". | ||
* If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/). | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of "eval-source-map"
for the devtool in a production build is discouraged due to performance and security reasons. Consider using a more production-appropriate source map type for minimizing and debugging production builds efficiently.
- * ATTENTION: An "eval-source-map" devtool has been used.
+ * Consider using a more production-appropriate source map type for production builds.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
/* | |
* ATTENTION: An "eval-source-map" devtool has been used. | |
* This devtool is neither made for production nor for readable output files. | |
* It uses "eval()" calls to create a separate source file with attached SourceMaps in the browser devtools. | |
* If you are trying to read the output file, select a different devtool (https://webpack.js.org/configuration/devtool/) | |
* or disable the default devtool with "devtool: false". | |
* If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/). | |
*/ | |
/* | |
* Consider using a more production-appropriate source map type for production builds. | |
* This devtool is neither made for production nor for readable output files. | |
* It uses "eval()" calls to create a separate source file with attached SourceMaps in the browser devtools. | |
* If you are trying to read the output file, select a different devtool (https://webpack.js.org/configuration/devtool/) | |
* or disable the default devtool with "devtool: false". | |
* If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/). | |
*/ |
tenscan_logs.txt
Outdated
INFO [01-10|17:16:38.878] Created Obscuro Scan with the following: component=tenscan args="&{NodeHostAddress:http://erpc.dev-testnet.ten.xyz:80 ServerAddress:0.0.0.0:80 LogPath:tenscan_logs.txt}" | ||
INFO [01-10|17:16:38.881] Starting server on 0.0.0.0:80 component=tenscan | ||
ERROR[01-10|17:26:29.586] unable to execute request Post "http://erpc.dev-testnet.ten.xyz:80": read tcp 192.168.1.104:50252->51.11.135.65:80: read: operation timed out component=tenscan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tenscan_logs.txt
file logs indicate successful server startup and an error related to a timed-out operation. Ensure error handling is robust and consider implementing retry logic or alerting mechanisms for critical failures.
+ // Consider adding retry logic for timed-out operations
+ // Implement alerting for critical errors
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
INFO [01-10|17:16:38.878] Created Obscuro Scan with the following: component=tenscan args="&{NodeHostAddress:http://erpc.dev-testnet.ten.xyz:80 ServerAddress:0.0.0.0:80 LogPath:tenscan_logs.txt}" | |
INFO [01-10|17:16:38.881] Starting server on 0.0.0.0:80 component=tenscan | |
ERROR[01-10|17:26:29.586] unable to execute request Post "http://erpc.dev-testnet.ten.xyz:80": read tcp 192.168.1.104:50252->51.11.135.65:80: read: operation timed out component=tenscan | |
INFO [01-10|17:16:38.878] Created Obscuro Scan with the following: component=tenscan args="&{NodeHostAddress:http://erpc.dev-testnet.ten.xyz:80 ServerAddress:0.0.0.0:80 LogPath:tenscan_logs.txt}" | |
INFO [01-10|17:16:38.881] Starting server on 0.0.0.0:80 component=tenscan | |
ERROR[01-10|17:26:29.586] unable to execute request Post "http://erpc.dev-testnet.ten.xyz:80": read tcp 192.168.1.104:50252->51.11.135.65:80: read: operation timed out component=tenscan | |
// Consider adding retry logic for timed-out operations | |
// Implement alerting for critical errors |
8e9c62c
to
b6ebcd9
Compare
Replayed your commit Pedro but with the tenscan stuff removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems to be working in sepolia
Why this change is needed
Please provide a description and a link to the underlying ticket
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks