Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts gateway VM deployment to use static ip address. #1781

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

anixon604
Copy link
Contributor

Why this change is needed

We have intermittent issues with the Gateway not being accessible on redeploy from what is believed to be DNS delay from the dynamic IP. Static IPs on the VM will solve this.

Note: originally I had planned to introduce a LoadBalancer, but decided against as the backend pools will balance as well and the static IPs will be more cost effective. (however this will be deprecated when migration to terraform is in place as the below workflow doesn't accommodate multiple instances / horizontal scaled gateways.

What changes were made as part of this PR

  • check/create a static ip for use
  • assigns the vm the existing ip

PR checks pre-merging

N/A for workflow

@anixon604 anixon604 self-assigned this Feb 9, 2024
@anixon604 anixon604 marked this pull request as ready for review February 29, 2024 11:05
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending successful run

@anixon604
Copy link
Contributor Author

Checked on dev-testnet, caught but where had to move the dns assignment from the vm flag, to attach to the pre-defined static-ip. This dns-name check/assignment is added as a prior step.

@anixon604 anixon604 merged commit b062874 into main Feb 29, 2024
3 checks passed
@anixon604 anixon604 deleted the anthony/OG-static-ip branch February 29, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants