Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak cache params #1801

Merged
merged 1 commit into from
Feb 19, 2024
Merged

tweak cache params #1801

merged 1 commit into from
Feb 19, 2024

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

This is a naive fix for the OOM.

In a future version we have to make more rigorous calculations.

What changes were made as part of this PR

  • decrease the number of elements to be cached

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

MaxCost: 1 << 28, // maximum cost of cache (256MB).
BufferItems: 64, // number of keys per Get buffer. Todo - what is this
NumCounters: 5000, // number of keys to track frequency of.
MaxCost: 500, // todo - this represents how many items.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the default "cost" for an item is 1

Copy link
Contributor

@zkokelj zkokelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-malene tudor-malene merged commit 2ab4fc3 into main Feb 19, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/tweak_cache_size branch February 19, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants