NetworkTests: add options for test users to use gateway #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
approved these changes
Feb 20, 2024
zkokelj
approved these changes
Feb 20, 2024
zkokelj
pushed a commit
that referenced
this pull request
Feb 21, 2024
zkokelj
added a commit
that referenced
this pull request
Feb 21, 2024
* fix cache for authenticated method calls * fix mutex error * NetworkTests: add options for test users to use gateway (#1806) --------- Co-authored-by: Matt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
The network tests are useful for end-to-end testing from the IDE against a local network or against the testnet environments.
But they could only test the direct to node 'AuthClient' connections and so they couldn't be used to debug or test GW issues.
What changes were made as part of this PR
WithGateway()option to the LocalDevNetwork so it starts a (debuggable) gateway process alongside the network nodes.UseGatewayboolean option to theCreateTestUseraction to allow users to be created that would register and communicate with the gateway instead of directly. (Create User abstraction so both types of user can be used in all tests).PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks