Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mutex error #1810

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix mutex error #1810

merged 1 commit into from
Feb 21, 2024

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Feb 21, 2024

Why this change is needed

We experienced crashes on testnet and this is the most likely cause of them.
We were using only read mutex, but we also need write mutex to avoid concurrent write

What changes were made as part of this PR

Change read mutex to read+write mutex

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@zkokelj zkokelj marked this pull request as ready for review February 21, 2024 10:54
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zkokelj zkokelj merged commit b7bea2c into main Feb 21, 2024
1 of 2 checks passed
@zkokelj zkokelj deleted the ziga/fix_gateway_mutex_error branch February 21, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants