Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch limit: increase max to 36kb #1817

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Batch limit: increase max to 36kb #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48bb8cd
Batch limit: increase max to 36kb
BedrockSquirrel Feb 27, 2024
03e1517
missed a couple
BedrockSquirrel Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/config/enclave_cli_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ var EnclaveFlags = map[string]*flag.TenFlag{
MinGasPriceFlag: flag.NewInt64Flag(MinGasPriceFlag, 1, "The minimum gas price for mining a transaction"),
MessageBusAddressFlag: flag.NewStringFlag(MessageBusAddressFlag, "", "The address of the L1 message bus contract owned by the management contract."),
SequencerIDFlag: flag.NewStringFlag(SequencerIDFlag, "", "The 20 bytes of the address of the sequencer for this network"),
MaxBatchSizeFlag: flag.NewUint64Flag(MaxBatchSizeFlag, 1024*32, "The maximum size a batch is allowed to reach uncompressed"),
MaxBatchSizeFlag: flag.NewUint64Flag(MaxBatchSizeFlag, 1024*36, "The maximum size a batch is allowed to reach uncompressed"),
MaxRollupSizeFlag: flag.NewUint64Flag(MaxRollupSizeFlag, 1024*64, "The maximum size a rollup is allowed to reach"),
L2BaseFeeFlag: flag.NewUint64Flag(L2BaseFeeFlag, params.InitialBaseFee, ""),
L2CoinbaseFlag: flag.NewStringFlag(L2CoinbaseFlag, "0xd6C9230053f45F873Cb66D8A02439380a37A4fbF", ""),
Expand Down
2 changes: 1 addition & 1 deletion go/node/docker_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func (d *DockerNode) startEnclave() error {
"-logPath", "sys_out",
"-logLevel", fmt.Sprintf("%d", log.LvlInfo),
fmt.Sprintf("-debugNamespaceEnabled=%t", d.cfg.debugNamespaceEnabled),
"-maxBatchSize=32768",
"-maxBatchSize=36864",
"-maxRollupSize=65536",
fmt.Sprintf("-logLevel=%d", d.cfg.logLevel),
"-obscuroGenesis", "{}",
Expand Down
2 changes: 1 addition & 1 deletion integration/common/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func DefaultEnclaveConfig() *config.EnclaveConfig {
SequencerID: gethcommon.BytesToAddress([]byte("")),
ObscuroGenesis: "",
DebugNamespaceEnabled: false,
MaxBatchSize: 1024 * 32,
MaxBatchSize: 1024 * 36,
MaxRollupSize: 1024 * 64,
GasPaymentAddress: gethcommon.HexToAddress("0xd6C9230053f45F873Cb66D8A02439380a37A4fbF"),
BaseFee: new(big.Int).SetUint64(params.InitialBaseFee),
Expand Down
2 changes: 1 addition & 1 deletion integration/simulation/devnetwork/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ func (n *InMemNodeOperator) createEnclaveContainer() *enclavecontainer.EnclaveCo
MessageBusAddress: n.l1Data.MessageBusAddr,
SqliteDBPath: n.enclaveDBFilepath,
DebugNamespaceEnabled: true,
MaxBatchSize: 1024 * 32,
MaxBatchSize: 1024 * 36,
MaxRollupSize: 1024 * 64,
BaseFee: defaultCfg.BaseFee, // todo @siliev:: fix test transaction builders so this can be different
GasBatchExecutionLimit: defaultCfg.GasBatchExecutionLimit,
Expand Down
2 changes: 1 addition & 1 deletion integration/simulation/network/network_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func createInMemObscuroNode(
MinGasPrice: gethcommon.Big1,
MessageBusAddress: l1BusAddress,
ManagementContractAddress: *mgtContractAddress,
MaxBatchSize: 1024 * 32,
MaxBatchSize: 1024 * 36,
MaxRollupSize: 1024 * 64,
BaseFee: big.NewInt(1), // todo @siliev:: fix test transaction builders so this can be different
GasLocalExecutionCapFlag: params.MaxGasLimit / 2,
Expand Down
Loading