store incoming transactions in a database #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BedrockSquirrel
approved these changes
Mar 5, 2024
| id INT AUTO_INCREMENT PRIMARY KEY, | ||
| user_id varbinary(20), | ||
| tx TEXT, | ||
| tx_time DATETIME DEFAULT CURRENT_TIMESTAMP |
There was a problem hiding this comment.
Wonder if it be possible to store the tx hash as well or is that going to be too expensive to figure out on the fly? Just thinking about being able to do lookups if investigating an issue.
BedrockSquirrel
requested changes
Mar 5, 2024
| w.Logger().Error(fmt.Errorf("error decoding string (%s), %w", hexUserID[2:], err).Error()) | ||
| return nil, errors.New("error decoding userID. It should be in hex format") | ||
| } | ||
| err = w.storage.StoreTransaction(request.Params[0].(string), userIDBytes) |
There was a problem hiding this comment.
Are we 100% certain that the first param exists, can be cast to a string and will have "0x" as the first two characters so you can strip them off?
There was a problem hiding this comment.
Things are checked in a function that calls that function, but added additional check there to avoid an edge case that might happen.
| // Calculate tx hash | ||
| rawTxBytes, err := hex.DecodeString(rawTx[2:]) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
We shouldn't panic here imo, just log the error and store it without the tx hash. (Same on the sqlite impl)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
For debugging purposes we would like to store unencrypted transactions in the gateway to be able to reproduce some errors if they occur.
What changes were made as part of this PR
Additional database table, storing transactions
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks
https://github.com/ten-protocol/ten-test/actions/runs/8143119529