Refactor OG RPC - Superseded #1832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tools/walletextension/httpapi/routes.go # tools/walletextension/storage/database/mariadb/mariadb.go # tools/walletextension/storage/database/sqlite/sqlite.go # tools/walletextension/wallet_extension.go
tudor-malene
commented
Mar 11, 2024
integration/common/utils.go
Outdated
| @@ -49,11 +48,13 @@ func AwaitReceipt(ctx context.Context, client *obsclient.AuthObsClient, txHash g | |||
| var err error | |||
| err = retry.Do(func() error { | |||
| receipt, err = client.TransactionReceipt(ctx, txHash) | |||
| if err != nil && !errors.Is(err, rpc.ErrNilResponse) { | |||
| // we only retry for a nil "not found" response. This is a different error, so we bail out of the retry loop | |||
| if err != nil { | |||
There was a problem hiding this comment.
the ErrNilResponse error is non-standard
tudor-malene
commented
Mar 11, 2024
| @@ -389,7 +397,7 @@ func testErrorHandling(t *testing.T, httpURL, wsURL string, w wallet.Wallet) { | |||
| for _, req := range []string{ | |||
| `{"jsonrpc":"2.0","method":"eth_getBalance","params":["0xA58C60cc047592DE97BF1E8d2f225Fc5D959De77", "latest"],"id":1}`, | |||
| `{"jsonrpc":"2.0","method":"eth_getBalance","params":[],"id":1}`, | |||
| `{"jsonrpc":"2.0","method":"eth_getgetget","params":["0xA58C60cc047592DE97BF1E8d2f225Fc5D959De77", "latest"],"id":1}`, | |||
| //`{"jsonrpc":"2.0","method":"eth_getgetget","params":["0xA58C60cc047592DE97BF1E8d2f225Fc5D959De77", "latest"],"id":1}`, | |||
There was a problem hiding this comment.
commented for now as it fails in a different place
|
split into smaller bits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
current code is structured for different assumptions, and does not permit extension
What changes were made as part of this PR
-todo
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks